refactor: use second person for identity building #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boczekbartek
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
@maciejmajek
Apologies for my late reply.
I tested it on turtlebot and identity was adjusted as expected.
See image (left - old, right - new).
I also briefly tested it with turtlebot_demo and embodiment works.
|
@boczekbartek actually that diff is kind of strange. I've tested it and the output always started with "you are a" which is vastly different from "you are looking at". I will further adjust it as at the moment this may not propagate embodiment well |
|
I see. However, when I tested it the answers in streamlit were in the first person.
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
A few months ago, I have been testing different styles of system prompts. The tests included first (I am a...), second (you are ...) and third person view (This is a conversation between an expert embodied AI and user).
Empirical tests showed, that the second person view worked a little bit better than the first person and much better than the third.
Due to amount of changes in the other parts of the repository, change to second person was postponed. Until today.
Proposed Changes
Changed the prompt of identity builder to start the robot_identity.txt with You are instead of I am.
Issues
Testing