-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve whoami docs #239
Conversation
4cf9c57
to
a04588a
Compare
a04588a
to
90a1934
Compare
e13e09a
to
9e92c9b
Compare
9e92c9b
to
12804c6
Compare
docs/create_robots_whoami.md
Outdated
|
||
``` | ||
poetry run parse_whoami_package src/examples/panda_whoami/description src/examples/panda_whoami/description | ||
> **NOTE**: Vector database is created using the OpenAI API. Parsing bigger documents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not true, the vendor is used based on config.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know! I tested ollama
and it worked! Docs adjusted
docs/create_robots_whoami.md
Outdated
@@ -33,16 +38,14 @@ You can test your new `panda_whoami` package by calling `rai_whoami` services: | |||
|
|||
2. Building and sourcing the install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the title is not a little bit off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the comments. Apart from them LGTM
2f82430
to
44392f0
Compare
@maciejmajek I addressed your comments |
Purpose
Proposed Changes
Issues
Testing