Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve whoami docs #239

Merged
merged 5 commits into from
Sep 26, 2024
Merged

docs: improve whoami docs #239

merged 5 commits into from
Sep 26, 2024

Conversation

boczekbartek
Copy link
Member

Purpose

  • improves documentation

Proposed Changes

Issues

Testing

@boczekbartek boczekbartek marked this pull request as ready for review September 25, 2024 13:20

```
poetry run parse_whoami_package src/examples/panda_whoami/description src/examples/panda_whoami/description
> **NOTE**: Vector database is created using the OpenAI API. Parsing bigger documents
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not true, the vendor is used based on config.toml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know! I tested ollama and it worked! Docs adjusted

@@ -33,16 +38,14 @@ You can test your new `panda_whoami` package by calling `rai_whoami` services:

2. Building and sourcing the install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the title is not a little bit off

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@maciejmajek maciejmajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the comments. Apart from them LGTM

@boczekbartek boczekbartek mentioned this pull request Sep 25, 2024
1 task
@boczekbartek
Copy link
Member Author

@maciejmajek I addressed your comments

@maciejmajek maciejmajek merged commit 4cc7e7b into development Sep 26, 2024
4 checks passed
@maciejmajek maciejmajek deleted the fix/docs branch September 26, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants