Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs and code): text_hmi #238

Merged
merged 3 commits into from
Sep 24, 2024
Merged

fix(docs and code): text_hmi #238

merged 3 commits into from
Sep 24, 2024

Conversation

maciejmajek
Copy link
Member

Purpose

Readme included wrong command for running the default streamlit based hmi.

Proposed Changes

  • fix: typo in compare statement
  • feat: allow empty identity and constitution in base hmi node
  • docs: update text hmi command

Issues

  • Links to relevant issues

Testing

Manually tested using

streamlit run src/rai_hmi/rai_hmi/text_hmi.py

and

ros2 run rai_whoami rai_whoami_node --ros-args -p robot_description_package:="rosbot_xl_whoami" & 
streamlit run src/rai_hmi/rai_hmi/text_hmi.py "rosbot_xl_whoami"

@maciejmajek maciejmajek merged commit 3ca9866 into development Sep 24, 2024
4 checks passed
@maciejmajek maciejmajek deleted the fix/text_hmi branch September 24, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants