feat(rai_cli): improved UX #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boczekbartek
requested changes
Sep 4, 2024
src/rai/rai/cli/rai_cli.py
Outdated
|
|
||
| def build_docs_vector_store(): | ||
| logger.info("Building the robot docs vector store...") | ||
| faiss_index = FAISS.from_documents(docs, OpenAIEmbeddings()) |
There was a problem hiding this comment.
Same here, we should avoid hard OpenAI dependency and make it interchangeable with OpenSource solution
maciejmajek
force-pushed
the
feat/rai-cli-ux
branch
from
fd5432c to
02ab2f4
Compare
maciejmajek
force-pushed
the
feat/rai-cli-ux
branch
from
a63bcdf to
e67ba7f
Compare
boczekbartek
reviewed
Sep 4, 2024
maciejmajek
force-pushed
the
feat/rai-cli-ux
branch
from
4fa290b to
940aa25
Compare
boczekbartek
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
@maciejmajek 1 minor fix. Besides that I've tested the code and it LGTM!
…ions feat(model_initialization): add functions to initialize LLM and embeddings models based on config file
Co-authored-by: Bartłomiej Boczek <[email protected]>
…el_initialization.py files for legal compliance and clarity
Co-authored-by: Bartek Boczek <[email protected]>
maciejmajek
force-pushed
the
feat/rai-cli-ux
branch
from
90dff6d to
d86f67b
Compare
maciejmajek
added a commit
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR improves user's experience during building documentation vector store and robot identity.
Proposed Changes
rai_cli now informs the user about possible costs during build.
Issues
Testing
To recreate testing environment, run:
vcs import < demos.repos