Feature/reflectivity #341
Open
Feature/reflectivity #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prybicki
requested changes
Dec 10, 2024
| /** | ||
| * Modifies RaytraceNode to set reflectivity alpha. | ||
| * Reflectivity alpha is used to calculate reflectivity of the hit point. This value is constant for every hit point. | ||
| * Default reflectivity alpha is set to 0.1f. |
There was a problem hiding this comment.
What's the reason behind this 0.1f choice?
Comment on lines
+130
to
+132
| if (ctx->reflectivityF32 != nullptr) { | ||
| ctx->reflectivityF32[returnPointIdx] = ctx->mrSamples.reflectivity[sampleIdx]; | ||
| } |
There was a problem hiding this comment.
Here you can use selected sample to compute reflectivity. This way reflectivity can be removed from multi-return samples to save memory.
This suggestion was NOT COMPILED.
Suggested change
| if (ctx->reflectivityF32 != nullptr) { | |
| ctx->reflectivityF32[returnPointIdx] = ctx->mrSamples.reflectivity[sampleIdx]; | |
| } | |
| if (ctx->reflectivityF32 != nullptr) { | |
| auto distance2 = ctx->mrSamples.intensity[sampleIdx] * ctx->mrSamples.intensity[sampleIdx]; | |
| ctx->reflectivityF32[returnPointIdx] = reflectivityAlpha * ctx->mrSamples.intensity[sampleIdx] * distance2; | |
| } |
| @@ -27,6 +27,7 @@ struct MultiReturnSamplesPointers | |||
| Field<IS_HIT_I32>::type* isHit; | |||
| Field<DISTANCE_F32>::type* distance; | |||
| Field<INTENSITY_F32>::type* intensity; | |||
| Field<REFLECTIVITY_F32>::type* reflectivity; | |||
|
|
||
| TEST_P(ReflectivityTest, read_value) | ||
| { | ||
| auto [alpha, value] = GetParam(); |
There was a problem hiding this comment.
Please parametrize also distance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the concept of reflectivity to the RaytraceNode, allowing for the calculation and configuration of reflectivity values in ray-tracing operations.
Reflectivity Feature Addition:
RGL_FIELD_REFLECTIVITY_F32to thergl_field_t.rgl_node_raytrace_configure_reflectivity_alphato configure reflectivity alpha values for RaytraceNodeTesting:
reflectivityTest.cppto cover the new reflectivity functionality.