Add handling nan radial speeds in radar nodes #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng nodes. Signed-off-by: Paweł Liberadzki <[email protected]>
msz-rai
approved these changes
Jun 17, 2024
msz-rai
merged commit 0ee28c9
into
feature/radar-object-classification
20 checks passed
msz-rai
pushed a commit
that referenced
this pull request
Jun 17, 2024
Add handling nan radial speeds in radar postprocess and object tracking nodes. Signed-off-by: Paweł Liberadzki <[email protected]>
msz-rai
added a commit
that referenced
this pull request
Jun 20, 2024
* Add initial support for object classification in RadarTrackObjectsNode. Signed-off-by: Paweł Liberadzki <[email protected]> * Add API call for setting radar object classes. Signed-off-by: Paweł Liberadzki <[email protected]> * Update radar track objects tests to handle object ids. Signed-off-by: Paweł Liberadzki <[email protected]> * Add safety static_cast. Signed-off-by: Paweł Liberadzki <[email protected]> * Make fixes based on the review. Signed-off-by: Paweł Liberadzki <[email protected]> * Prevent underflow in loop condition (#308) * Add handling nan radial speeds in radar nodes (#309) Add handling nan radial speeds in radar postprocess and object tracking nodes. Signed-off-by: Paweł Liberadzki <[email protected]> * Radar object classification improvements (#310) * Change array type in fieldData to be compatible with all RGL nodes * Use velocities from raytrace instead of calculating it again (better accuracy) * Do not output predicted objects * Restore the conditions of merging detections into objects * Fix required fields; skip test that fails * Require detections in world frame to predict objects properly * Fix displacementFromSkinning calculation * Fix test * Put all objects to the output * Fix deltaTime calculation * Fix test * Fix time * Fix passing time to new objects * Add comment on skinning fix * Fix coordinate system of width & length * Fix bounding boxes * Fix maxClassificationProbability * Change unit of movement_sensitivity --------- Signed-off-by: Paweł Liberadzki <[email protected]> Co-authored-by: Maja Nagarnowicz <[email protected]> Co-authored-by: Mateusz Szczygielski <[email protected]>
msz-rai
added a commit
that referenced
this pull request
Jul 13, 2024
* Add initial support for object classification in RadarTrackObjectsNode. Signed-off-by: Paweł Liberadzki <[email protected]> * Add API call for setting radar object classes. Signed-off-by: Paweł Liberadzki <[email protected]> * Update radar track objects tests to handle object ids. Signed-off-by: Paweł Liberadzki <[email protected]> * Add safety static_cast. Signed-off-by: Paweł Liberadzki <[email protected]> * Make fixes based on the review. Signed-off-by: Paweł Liberadzki <[email protected]> * Prevent underflow in loop condition (#308) * Add handling nan radial speeds in radar nodes (#309) Add handling nan radial speeds in radar postprocess and object tracking nodes. Signed-off-by: Paweł Liberadzki <[email protected]> * Radar object classification improvements (#310) * Change array type in fieldData to be compatible with all RGL nodes * Use velocities from raytrace instead of calculating it again (better accuracy) * Do not output predicted objects * Restore the conditions of merging detections into objects * Fix required fields; skip test that fails * Require detections in world frame to predict objects properly * Fix displacementFromSkinning calculation * Fix test * Put all objects to the output * Fix deltaTime calculation * Fix test * Fix time * Fix passing time to new objects * Add comment on skinning fix * Fix coordinate system of width & length * Fix bounding boxes * Fix maxClassificationProbability * Change unit of movement_sensitivity --------- Signed-off-by: Paweł Liberadzki <[email protected]> Co-authored-by: Maja Nagarnowicz <[email protected]> Co-authored-by: Mateusz Szczygielski <[email protected]>
msz-rai
added a commit
that referenced
this pull request
Jul 15, 2024
* Add initial support for object classification in RadarTrackObjectsNode. Signed-off-by: Paweł Liberadzki <[email protected]> * Add API call for setting radar object classes. Signed-off-by: Paweł Liberadzki <[email protected]> * Update radar track objects tests to handle object ids. Signed-off-by: Paweł Liberadzki <[email protected]> * Add safety static_cast. Signed-off-by: Paweł Liberadzki <[email protected]> * Make fixes based on the review. Signed-off-by: Paweł Liberadzki <[email protected]> * Prevent underflow in loop condition (#308) * Add handling nan radial speeds in radar nodes (#309) Add handling nan radial speeds in radar postprocess and object tracking nodes. Signed-off-by: Paweł Liberadzki <[email protected]> * Radar object classification improvements (#310) * Change array type in fieldData to be compatible with all RGL nodes * Use velocities from raytrace instead of calculating it again (better accuracy) * Do not output predicted objects * Restore the conditions of merging detections into objects * Fix required fields; skip test that fails * Require detections in world frame to predict objects properly * Fix displacementFromSkinning calculation * Fix test * Put all objects to the output * Fix deltaTime calculation * Fix test * Fix time * Fix passing time to new objects * Add comment on skinning fix * Fix coordinate system of width & length * Fix bounding boxes * Fix maxClassificationProbability * Change unit of movement_sensitivity --------- Signed-off-by: Paweł Liberadzki <[email protected]> Co-authored-by: Maja Nagarnowicz <[email protected]> Co-authored-by: Mateusz Szczygielski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to title. Nan radial speeds are result of processing in raytrace node, with delta time equalt to 0 (0 by 0 division).