Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop relying on incompatible_legacy_whole_archive #12137

Closed
EricCousineau-TRI opened this issue Oct 3, 2019 · 7 comments · Fixed by #12262
Closed

Stop relying on incompatible_legacy_whole_archive #12137

EricCousineau-TRI opened this issue Oct 3, 2019 · 7 comments · Fixed by #12262

Comments

@EricCousineau-TRI
Copy link
Contributor

EricCousineau-TRI commented Oct 3, 2019

See PR #12124

Things break for shared libraries (at least our formulation)?

EDIT: Slack convo: https://drakedevelopers.slack.com/archives/C2PMBJVAN/p1569944216009500

\cc @jwnimmer-tri

@jwnimmer-tri
Copy link
Collaborator

Yes, we need --incompatible_remove_legacy_whole_archive=false as a stopgap, and then some alwayslink = 1 repairs to pydrake later in order to undo that flag.

@EricCousineau-TRI
Copy link
Contributor Author

We've worked around this via #12150, so closing this for now.
Descoping this issue from actually upgrading 1.0.0 across the board, just to focus on the Mac upgrade as well as Python uprgade.

@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Oct 17, 2019

Where is the tracking issue to remove --incompatible_remove_legacy_whole_archive=false as a requirement in our rcfiles? Users who consume us like bazel_drake_external currently have a pain point where they need to change their own project in order to consume Drake.

(I would like to see us remove that flag in the next few weeks.)

@EricCousineau-TRI
Copy link
Contributor Author

SGTM. Reopening, but lowering priority.

@jwnimmer-tri
Copy link
Collaborator

@EricCousineau-TRI The other, more important build system transitions seem to be making good progress. I'd like to see this issue fixed prior to the v0.12 release (so, merged to master in the next week or so). If that's not possible, please re-assign this issue to me to work on it.

@EricCousineau-TRI
Copy link
Contributor Author

Spoke with @jamiesnape and it'd be feasible, but not in time for 0.12 release. I'll reassign to you for the time being. Thanks!

@jwnimmer-tri jwnimmer-tri changed the title Should fix for bazel 1.0.0 Stop relying on incompatible_legacy_whole_archive Oct 29, 2019
@jwnimmer-tri
Copy link
Collaborator

For the record, trying to fix this has uncovered several challenges. I don't think it will make the v0.12.0 release cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants