bump builds on all vincas, ros2_control, ros2_controllers, control-toolbox, gazebo-ros2-control #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure this can work. Basically this may change the ABI of ros2_control packages, so we should rebuild all the downstream packages. That is the reason why we associate this kind of bumps with full rebuilds. |
|
I can add back all the dependent packages. |
To be honest, I am not sure about that, probably @wolfv or @Tobias-Fischer can know more. |
|
@wolfv , @Tobias-Fischer , any comments? |
|
I'm personally against bumping just some package versions. We should rebuild all packages as @traversaro suggested because of potential ABI compatibility. In other words, we need a full rebuild. If you want to fix all patches that are broken @sonelu I could try and find some time to do the remaining chores for it. |
|
@Tobias-Fischer I can certainly try. When you say "patches that are broken" where do I see that? Do we just run a full list and then take all the eventual errors and fix them? Or another idea: can we setup a new run and build only |
|
Yes that sounds like a good suggestion. I personally recommend doing the build locally first as it is a lot faster to iterate. |
|
I can definitely do that. I read through the instruction for building it locally, but I have a question: it only builds the native architecture (i.e. I need linux-64 to build the linux-64 version, Mac OS to build the osx version, and arm64 (raspberry pi?) to build the linux-aarch64, etc.)? Or can you cross build on a linux-64 machine? |
|
You can cross build, but the native builds should be sufficient :). Also you can use the “—skip-existing=fast” flag for boa to avoid building already built packages. |
|
Ok, I'll have a try and see how it goes. |
|
For cross builds see ros-humble/.github/workflows/testpr.yml Line 185 in 71d4b56 |
|
OK, I've done a local build for If that's ok then I can already put a PR for linux-64 and test the aarch64. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased build number for all lists as follows and included for build only:
Fixes #203