Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt jupyter-releaser #114

Merged
merged 14 commits into from
Aug 10, 2022
Merged

Conversation

IsabelParedes
Copy link
Collaborator

This changes the configuration to be able to use jupyter-releaser by following the instructions given in Convert a Repo to Use Releaser.

When tested locally, this command succeeds with some warnings

jupyter-releaser prep-git --branch jupyter-releaser
WARNING: jupyros 0.5.0 does not provide the extra 'dev'
WARNING: jupyros 0.5.0 does not provide the extra 'test'

However, this fails

jupyter-releaser build-python

with the following (truncated) output message:

* Building wheel...
running bdist_wheel
running js
Installing build dependencies with npm.  This may take a while...
> jlpm install
error: [Errno 2] No such file or directory: '/tmp/build-via-sdist-wrueqmhk/jupyros-0.5.0/js'

ERROR Backend subprocess exited when trying to invoke build_wheel

No GitHub Actions have been created yet to check the release.

@IsabelParedes IsabelParedes added the enhancement New feature or request label Jul 29, 2022
@IsabelParedes IsabelParedes requested a review from hbcarlos July 29, 2022 15:13
@IsabelParedes IsabelParedes self-assigned this Jul 29, 2022
@hbcarlos
Copy link
Member

hbcarlos commented Aug 2, 2022

Thanks, @ihuicatl! It would be interesting to add the GitHub action check-release. This way, we could see what is missing.
https://github.com/ihuicatl/jupyterlab-urdf/blob/main/.github/workflows/check-release.yml

@IsabelParedes
Copy link
Collaborator Author

After updating the MANIFEST, jupyter-releaser build-python runs successfully.

@IsabelParedes IsabelParedes force-pushed the jupyter-releaser branch 2 times, most recently from 3491e6c to 7bd2179 Compare August 3, 2022 16:16
@IsabelParedes
Copy link
Collaborator Author

I added the GitHub action to check-release. Now the issue is with tbump.
jupyter-releaser bump-version fails with

Error: Invalid config: Missing keys: 'git', 'version'

which comes from tbump --non-interactive --only-patch 0.5.1

Still need to update the pyproject.toml file.

@IsabelParedes IsabelParedes marked this pull request as ready for review August 10, 2022 10:08
@hbcarlos hbcarlos merged commit 2be3189 into RoboStack:master Aug 10, 2022
@IsabelParedes IsabelParedes deleted the jupyter-releaser branch January 23, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants