Loading config path from ROS2 parameter #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See PR #52, this was merged by them. But they secretly modified the parameter name without documentation 😉 so this isn't obvious for users who transition from ROS1. |
|
You're right! |
|
Can we PLEASE get this merged? |
robertkurvits
pushed a commit
to DUT-Racing/rslidar_sdk
that referenced
this pull request
Feb 14, 2023
…onitor Feat/latency monitor
|
Would like to have this merged too. |
|
We have merged your PR to the dev_opt branch. Thanks to everyone. |
|
close the PR. |
|
What's the branching policy you are using if I may ask? I see: |
|
@Timple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, you added a feature to load config file path from ROS1 parameter, but you omitted ROS2. This feature is necessary to properly load the configuration file, which is placed outside the package location in ROS2.
I have also added printing out information, from what path the configuration file is currently loaded.
I created pull request with my solution for that.