Return json output instead of html when wrong token in Header Authorization #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return a JsonResponse instead of raising AuthenticationFailed Exception that is turned into the general html error by django. rest_framework.response.Response should not be used in middleware, will return django.template.response.ContentNotRenderedError.
jerryfletcher21
changed the title
|
Hey @jerryfletcher21 thank you very much for this PR. In fact, we should be using Please post a 15K Sats invoice with a long expiration time for a small DevFund tip. |
lnbc150u1pn8yxfhsp524awjx3pntzuzm2kax5te7mygc48k55g7k9672e3dml9su7qy9nqpp5q8prrwdt3yfrwtv4kpnu9esv02lexvzqhf5scc5r8203ca0hmu8sdqqxq9zf6sqcqzysrzjqdllz2m2fe9ukju5fdkjptcgehlkrv6xrswl7rgq4zrfws2d3yduwr8j0yqpv2sqqqqqqqlgqqqqp9sq2q9qxpqysgqkzryh86v5l03e6x8un4840g5595p2xp3hp0wv82ywyarlrmj9kphg7g8j5533hxcsgrx2sq5gu37glmjltfggn28w3253eyrae8yumspjqycmj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1246
In robosats/middleware.py return a JsonResponse instead of raising AuthenticationFailed Exception that is turned into the general html error by django.
rest_framework.response.Response should not be used in middleware, will return django.template.response.ContentNotRenderedError.
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.