-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added autoref to the docker #2352
base: ros2
Are you sure you want to change the base?
Conversation
Is adding an extra check for |
Can you show a screenshot or something of autoref running in the Docker container? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively you can just show me that it works in person today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in-person
Could you add steps to test (e.g., what commands to run) to the PR description? |
Just added some steps. Let me know if they need to be more detailed. |
Description
Describe your pull request.
Added autoref to docker.
Associated / Resolved Issue
Resolves # or ClickUp card
Design Documents
Link
Steps to Test
docker build -t -f Dockerfile.dev --build-arg TARGETARCH=amd64 .
Test Case 1
Expected result:???
Key Files to Review
Group 1
Group 2
Review Checklist
(Optional) Sub-issues (for drafts)
Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.