Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added autoref to the docker #2352

Open
wants to merge 1 commit into
base: ros2
Choose a base branch
from
Open

Added autoref to the docker #2352

wants to merge 1 commit into from

Conversation

jvogt23
Copy link
Contributor

@jvogt23 jvogt23 commented Feb 24, 2025

Description

Describe your pull request.
Added autoref to docker.

Associated / Resolved Issue

Resolves # or ClickUp card

Design Documents

Link

Steps to Test

  1. Run a manual docker build from the branch. The file is Dockerfile.dev so the command should be:
    docker build -t -f Dockerfile.dev --build-arg TARGETARCH=amd64 .
  2. After it finishes building, run it with commands similar to those in our docker hub site.
  3. Note that the autoref is in a directory by the same name in the root directory, and the binaries should be stored in a folder called "build" within that directory.
  4. After it starts up, log into it through vnc and run simulator-cli, the external ref (again using the commands listed on docker hub), then autoref, then our stack using run-sim-ex
  5. The autoref should give occasional feedback about the game state.

Test Case 1

  1. Step 1
  2. Step 2
  3. Step 3

Expected result:???

Key Files to Review

Group 1

  • File 1
  • File 2

Group 2

  • File 3
  • File 4

Review Checklist

  • Docstrings: All methods and classes should have the file appropriate docstrings which follow the guidelines in the "Contributing" page of our docs.
  • Remove extra print statements: Any print statements used for debugging should be removed
  • Tag reviewers: Tag some people for review and ping them on Slack

(Optional) Sub-issues (for drafts)

Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.

  • Step 1
  • Step 2

@rishiso
Copy link
Contributor

rishiso commented Feb 24, 2025

Is adding an extra check for TARGETARCH necessary? It is passed in as an arg to the build by default: Docker Docs

@rishiso
Copy link
Contributor

rishiso commented Feb 24, 2025

Can you show a screenshot or something of autoref running in the Docker container?

Copy link
Contributor

@rishiso rishiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively you can just show me that it works in person today

Copy link
Contributor

@rishiso rishiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in-person

@jacksherling
Copy link
Contributor

Could you add steps to test (e.g., what commands to run) to the PR description?

@jvogt23
Copy link
Contributor Author

jvogt23 commented Mar 3, 2025

Could you add steps to test (e.g., what commands to run) to the PR description?

Just added some steps. Let me know if they need to be more detailed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants