Fix Phan suppressions

RoboJackets · Feb 12, 2025 · 1e23e5d · 1e23e5d
1 parent 2cb6cd0
commit 1e23e5d
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 9 deletions.
diff --git a/.phan/config.php b/.phan/config.php
@@ -20,7 +20,9 @@
         'PhanInvalidFQSENInCallable',
         'PhanPartialTypeMismatchReturn',
         'PhanPossiblyFalseTypeArgumentInternal',
+        'PhanPossiblyUndeclaredMethod',
         'PhanReadOnlyProtectedProperty',
+        'PhanTypeSuspiciousStringExpression',
         'PhanUndeclaredClassMethod',
         'PhanUndeclaredFunctionInCallable',
         'PhanUndeclaredMethod',

diff --git a/app/Http/Controllers/SyncController.php b/app/Http/Controllers/SyncController.php
@@ -70,7 +70,7 @@ public function sync(Request $request): JsonResponse
                     $lastRequest['clickup_id'] === $request->clickup_id;
 
             if ($same) {
-                // @phan-suppress-next-line PhanPartialTypeMismatchArgumentInternal
+                // @phan-suppress-next-line PhanTypeMismatchArgumentInternal
                 if (! in_array($request->model_event, config('apiary.whitelisted_events'), true)) {
                     Log::info(
                         self::class.': Not syncing '.$request->username.' as it is a duplicate of last seen event'

diff --git a/app/Jobs/SyncClickUp.php b/app/Jobs/SyncClickUp.php
@@ -61,7 +61,7 @@ public function handle(): void
             }
 
             foreach ($this->teams as $team) {
-                // @phan-suppress-next-line PhanPartialTypeMismatchArgumentInternal
+                // @phan-suppress-next-line PhanTypeMismatchArgumentInternal
                 if (! array_key_exists($team, config('clickup.teams_to_spaces'))) {
                     continue;
                 }

diff --git a/app/Jobs/SyncGoogleGroups.php b/app/Jobs/SyncGoogleGroups.php
@@ -52,7 +52,7 @@ public function __construct(
     /**
      * Execute the job.
      *
-     * @phan-suppress PhanPartialTypeMismatchArgument
+     * @phan-suppress PhanTypeMismatchArgument
      * @phan-suppress PhanUndeclaredClassProperty
      */
     public function handle(): void
@@ -138,7 +138,7 @@ private function getAllGroups(): Collection
 
         return $teams->filter(
             static fn (object $team): bool => $team->google_group !== null
-                // @phan-suppress-next-line PhanPartialTypeMismatchArgumentInternal
+                // @phan-suppress-next-line PhanTypeMismatchArgumentInternal
                 && ! in_array($team->google_group, config('google.manual_groups'), true)
         )->mapWithKeys(
             static fn (object $team): array => [$team->name => $team->google_group]

diff --git a/app/Jobs/SyncKeycloak.php b/app/Jobs/SyncKeycloak.php
@@ -38,8 +38,6 @@ protected function __construct(
 
     /**
      * Execute the job.
-     *
-     * @phan-suppress PhanTypeSuspiciousStringExpression
      */
     public function handle(): void
     {

diff --git a/app/Jobs/SyncSUMS.php b/app/Jobs/SyncSUMS.php
@@ -45,7 +45,7 @@ protected function __construct(
     public function handle(): void
     {
         if (
-            // @phan-suppress-next-line PhanPartialTypeMismatchArgumentInternal
+            // @phan-suppress-next-line PhanTypeMismatchArgumentInternal
             in_array($this->username, config('sums.whitelisted_accounts'), true) &&
             ($this->is_access_active === false)
         ) {

diff --git a/app/Providers/HorizonServiceProvider.php b/app/Providers/HorizonServiceProvider.php
@@ -20,6 +20,7 @@ public function boot(): void
         parent::boot();
 
         if (config('horizon.master_supervisor_name') !== null) {
+            // @phan-suppress-next-line PhanTypeMismatchReturn
             MasterSupervisor::determineNameUsing(static fn (): string => config('horizon.master_supervisor_name'));
         }
     }
@@ -36,10 +37,11 @@ protected function gate(): void
 
     /**
      * Register any application services.
+     *
+     * @phan-suppress PhanTypeMismatchArgument
      */
     public function register(): void
     {
-        // @phan-suppress-next-line PhanPartialTypeMismatchArgument
         Horizon::routeSlackNotificationsTo(config('slack.endpoint'));
     }
 }
diff --git a/app/Services/GitHub.php b/app/Services/GitHub.php
@@ -462,7 +462,7 @@ private static function getInstallationToken(): string
     /**
      * Generate a new JWT to authenticate to the API as the GitHub App.
      *
-     * @phan-suppress PhanPartialTypeMismatchArgument
+     * @phan-suppress PhanTypeMismatchArgument
      */
     private static function generateJWT(): string
     {
-Original file line number
+Diff line change
@@ Expand Up / @@ -38,8 +38,6 @@ protected function __construct( @@
         /**
          * Execute the job.
-         *
-         * @phan-suppress PhanTypeSuspiciousStringExpression
          */
         public function handle(): void
         {
@@ Expand Down @@