Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update allowedHttpLinks.txt #979

Merged
merged 6 commits into from
Jan 16, 2025
Merged

Update allowedHttpLinks.txt #979

merged 6 commits into from
Jan 16, 2025

Conversation

sammygrey
Copy link
Contributor

Added resources for HTTP methods. Useful for another pull request I'm doing charting each of the HTTP methods for Roblox's HttpService showing if they are allowed, a short description of what they do, and linking to the Mozilla dev resource for each.

Added resources for HTTP methods. Useful for another pull request I'm doing charting each of the HTTP methods for Roblox's HttpService showing if they are allowed, a short description of what they do, and linking to the Mozilla dev resource for each.
@sammygrey sammygrey requested review from a team as code owners January 10, 2025 23:24
@sammygrey sammygrey requested a review from Nightriff January 10, 2025 23:24
@github-actions github-actions bot added the tools Makes non-content changes label Jan 10, 2025
@sammygrey
Copy link
Contributor Author

This is the pull request I would like to be merged to use these HTTP links: #978.
However, adding those HTTP links to tools/checks/utils/allowedHttpLinks.txt in the actual pull request results in failing checks which makes the pull request look unmergeable.

zovits
zovits previously approved these changes Jan 14, 2025
@sammygrey
Copy link
Contributor Author

had to update as it was desynced with main, maybe next approval

@IgnisRBX IgnisRBX merged commit 4a90383 into Roblox:main Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Makes non-content changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants