Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variadic CFrame methods #726

Merged
merged 6 commits into from
Jul 22, 2024

Conversation

Ketasaja
Copy link
Contributor

Changes

These methods are not fully documented as being variadic.

I don't know how to correctly document a variadic return when all returned values have known type, and didn't find examples, so I went with Luau's type syntax ...CFrame. Please tell me if this should instead be Variant or something else.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@Ketasaja Ketasaja requested a review from a team as a code owner July 21, 2024 13:09
@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label Jul 21, 2024
@github-actions github-actions bot added the changes requested This pull request has changes requested prior to merging label Jul 21, 2024
@Ketasaja Ketasaja force-pushed the fix-variadic-CFrame-methods branch from a968a03 to fdce126 Compare July 21, 2024 13:38
@IgnisRBX IgnisRBX merged commit 0a19d67 into Roblox:main Jul 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested This pull request has changes requested prior to merging engine reference Changes the Engine API Reference documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants