Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Selective parsers with child logger #1741

Merged
merged 32 commits into from
May 8, 2024
Merged

Feat: Selective parsers with child logger #1741

merged 32 commits into from
May 8, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented May 7, 2024 •
edited
Loading

Enabled by #1739
Addressing v19

This PR does the following changes:

@RobinTail RobinTail added enhancement New feature or request refactoring The better way to achieve the same result labels May 7, 2024
@RobinTail RobinTail added this to the v19 milestone May 7, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented May 7, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling f5ef3de on selective-parsers
into cc1fc6c on make-v19.

@RobinTail
Copy link
Owner Author

Parsers should actually run for OPTIONS:

  • because inputs must be processed
  • because middlewares should run
  • because options handling finishes only after running the attached middlewares.

@RobinTail RobinTail changed the title Feat: Selective parsers Feat: Selective parsers with child logger May 7, 2024
RobinTail
RobinTail commented May 7, 2024
View reviewed changes
src/config-type.ts Outdated Show resolved Hide resolved
@RobinTail RobinTail added the breaking Backward incompatible changes label May 7, 2024
RobinTail
RobinTail commented May 7, 2024
View reviewed changes
src/config-type.ts Outdated Show resolved Hide resolved
RobinTail
RobinTail commented May 8, 2024
View reviewed changes
src/server-helpers.ts Outdated Show resolved Hide resolved
@RobinTail RobinTail marked this pull request as ready for review May 8, 2024 11:06
RobinTail
RobinTail commented May 8, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@RobinTail RobinTail merged commit 9cc3ec7 into make-v19 May 8, 2024
11 checks passed
@RobinTail RobinTail deleted the selective-parsers branch May 8, 2024 12:13
@RobinTail RobinTail mentioned this pull request May 8, 2024
Merged
@RobinTail
Copy link
Owner Author

RobinTail commented May 8, 2024 •
edited
Loading

Documentation changed in 1a146fa

@RobinTail RobinTail mentioned this pull request May 9, 2024
Merged
RobinTail added a commit that referenced this pull request May 9, 2024
@RobinTail
Automatic default raw parser (#1745)
93aa7b6 
Due to #1741 , the default raw parser can now be set automatically, so
that the config option can now be only used for customizations.
@RobinTail RobinTail mentioned this pull request May 9, 2024
Merged
RobinTail added a commit that referenced this pull request May 9, 2024
@RobinTail
Logger adjustments for v19 (#1748)
3ca5502 
related to discussion #1716 and due to #1741
@RobinTail RobinTail mentioned this pull request May 11, 2024
Merged
RobinTail added a commit that referenced this pull request May 11, 2024
@RobinTail
Fix: child logger should be available when using attachRouting() (#…
8d32a37 
…1756)

Due to #1748 and #1741
@RobinTail RobinTail mentioned this pull request May 12, 2024
Merged
RobinTail added a commit that referenced this pull request May 12, 2024
@RobinTail
Cleanup: Removing the requirement on configuring rawParser (#1762)
28ed00e 
Due to #1741 and #1745
RobinTail added a commit that referenced this pull request May 13, 2024
@RobinTail
v19 is for Dime (#1692)
60a463c 
![image](https://github.com/RobinTail/express-zod-api/assets/13189514/f090c11f-4d73-409a-8546-5c586adb0afc)

Pebbles LaDime (Dime) Doe was a black transgender woman.


https://edition.cnn.com/2024/02/25/us/dime-doe-trial-south-carolina-federal-hate-crime/index.html

https://www.nbcnews.com/feature/nbc-out/south-carolina-death-marks-14th-black-transgender-woman-killed-u-n1040971

https://www.justice.gov/opa/pr/south-carolina-man-found-guilty-hate-crime-killing-transgender-woman-because-her-gender

Transgender women suffer too frequently from transphobic violence and
cruelty, being the less protected social group. I'd like to raise an
awareness of this problem. Humans should be creators — not killers. But
most importantly, I want every transgender girl to have an opportunity
to create applications quickly and, in general, learn to write code
easily in order to receive job offers and leave dangerously transphobic
territories for more favorable and civilized ones, and live happily
there. Protect transgender women.

------------------------------

This version is focused on making `express-zod-api` a complete `zod`
plugin. In this regard `withMeta` is removed in favor of the recommended
approach on extending `zod` functionality, which opens up opportunities
for new features and simplifies the consumer experience. Another
improvement has been made for parsers: they are now applied selectively
depending on the type of expected request.

- #1693 
- #1705 
- #1707 
- Theoretically #1631 
  - In advance #1708 
- #1726 
- #1736 
- #1741 
  - #1745 
  - #1762 
  - #1756 
  - #1766 
- #1730 
  - #1747 
  - #1748 
- #1755 
- #1760 

- Not included, but comes later: #1750 

⚠️ don't squash it, to avoid conflicts with #1750
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking Backward incompatible changes enhancement New feature or request refactoring The better way to achieve the same result
Projects
None yet
Milestone
v19
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail