Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: providing options to Result Handler #1612

Merged
merged 19 commits into from
Mar 16, 2024
Merged

Feat: providing options to Result Handler #1612

merged 19 commits into from
Mar 16, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Mar 10, 2024 •
edited
Loading

Related to discussion #1606

Instead of #1466 (previous attempt due to another occasion)

@RobinTail RobinTail added the enhancement New feature or request label Mar 10, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Mar 10, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 8a4c0da on feat-options-in-result-handler
into 6083837 on master.

RobinTail
RobinTail commented Mar 10, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs a test

RobinTail
RobinTail commented Mar 11, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs an update to the dataflow diagram

@RobinTail RobinTail added the documentation Improvements or additions to documentation label Mar 11, 2024
@RobinTail RobinTail changed the title Feat: providing options to Result Handler. Feat: providing options to Result Handler Mar 12, 2024
@RobinTail RobinTail marked this pull request as ready for review March 16, 2024 17:15
RobinTail
RobinTail commented Mar 16, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail merged commit 5f7dcd2 into master Mar 16, 2024
11 checks passed
@RobinTail RobinTail deleted the feat-options-in-result-handler branch March 16, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail