Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import PropTypes from 'prop-types'; #24

Merged
merged 2 commits into from
Sep 6, 2018
Merged

import PropTypes from 'prop-types'; #24

merged 2 commits into from
Sep 6, 2018

Conversation

RobertSasak
Copy link
Owner

Make it compatible with latest react versions.

@RobertSasak
Copy link
Owner Author

@ProGoogler Can you please merge this?

@ricocrescenzio95
Copy link

It would be better to merge this pull request, in my project the library doesn't work at all 😔

@azanli
Copy link
Collaborator

azanli commented May 30, 2018

Merged. Sorry for the delay. Thank you for your contribution.

@azanli azanli closed this May 30, 2018
@RobertSasak
Copy link
Owner Author

@friendly-robot This PR was never merged. Can you please actually merge it?

Copy link
Collaborator

@azanli azanli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separates PropTypes import from its own module.

@azanli azanli reopened this Sep 6, 2018
@azanli azanli merged commit 8563cf8 into RobertSasak:master Sep 6, 2018
@azanli
Copy link
Collaborator

azanli commented Sep 6, 2018

Woopsy daisy. This time it's really merged! Thanks for the heads up fellas.

@KnapSac
Copy link

KnapSac commented Oct 23, 2018

When I cloned this repo, it turned out that the code in the camera.js file wasn't actually changed to what this PR is proposing, can it be changed? It would make upgrading to a newer React Native version a lot easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants