Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pdp v3 #19

Merged
merged 16 commits into from
Sep 7, 2022
Merged

Pdp v3 #19

merged 16 commits into from
Sep 7, 2022

Conversation

RobertSamoilescu
Copy link
Owner

Splits the implementation into two classes: PartialDependence and TreePartialDependence.

The PartialDependence accepts a a prediction function similar to ALE, thus can be applied to any black-box model. In the background performs the same computation as sklearn with method='brute'.

The TreePartialDependece is a dedicated for some tree-based sklearn models for faster computation. In the background it performs the same computation as sklearn with method='recursion', kind='average', response_method='decision_function'.

Some advantages of this approach:

  • There is no need for the arguments response_method and method anymore which were a bit confusing.
  • Similar split as KernelShap and TreeShap -- consistency.
  • Simiplifies considerably the sanity checks.

@RobertSamoilescu RobertSamoilescu merged commit 115fc7d into pdp Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant