Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove ial on blockquote inside triple quoted #96

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Do not remove ial on blockquote inside triple quoted #96

merged 1 commit into from
Feb 21, 2022

Conversation

josevalim
Copy link
Collaborator

Closes #94.

@josevalim
Copy link
Collaborator Author

Since I was playing with the line scanner code not long ago, I thought I would give the fix a try!

@coveralls
Copy link

coveralls commented Feb 21, 2022

Pull Request Test Coverage Report for Build 0a2c9c2dcde30d2671a767f10b8f846e3190ffbd-PR-96

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.5%) to 96.507%

Totals Coverage Status
Change from base Build 199e8dd5d9f9a2fc0415a027ec3d6d8f1aeb7f08: 2.5%
Covered Lines: 884
Relevant Lines: 916

💛 - Coveralls

@RobertDober
Copy link
Owner

Hmm I had rejected this fix because I assumed (never assume of course) it would break the case where Milmazz was needing it.
Obviously I was wrong

Ty so much, I'll release 1.4.20 today (although 2022-02-22 would be funnier)

@RobertDober RobertDober merged commit 7c2b843 into RobertDober:rel-1.4.20 Feb 21, 2022
@josevalim josevalim deleted the jv-ial-blockquote-header branch February 21, 2022 09:54
RobertDober pushed a commit that referenced this pull request Feb 21, 2022
RobertDober pushed a commit that referenced this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants