Add SNMPInflight metric (prometheus#1119)

* Add SNMPInflight metric --------- Signed-off-by: Kakuya Ando <[email protected]> Signed-off-by: Robert Bergman <[email protected]>
RobertBergman · Feb 26, 2024 · 3d4e413 · 3d4e413
1 parent 862b410
commit 3d4e413
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/collector/collector.go b/collector/collector.go
@@ -275,6 +275,7 @@ type Metrics struct {
 	SNMPDuration           prometheus.Histogram
 	SNMPPackets            prometheus.Counter
 	SNMPRetries            prometheus.Counter
+	SNMPInflight           prometheus.Gauge
 }
 
 type NamedModule struct {
@@ -346,7 +347,9 @@ func (c Collector) collect(ch chan<- prometheus.Metric, logger log.Logger, clien
 	)
 	start := time.Now()
 	moduleLabel := prometheus.Labels{"module": module.name}
+	c.metrics.SNMPInflight.Inc()
 	results, err := ScrapeTarget(client, c.target, c.auth, module.Module, logger, c.metrics)
+	c.metrics.SNMPInflight.Dec()
 	if err != nil {
 		level.Info(logger).Log("msg", "Error scraping target", "err", err)
 		ch <- prometheus.NewInvalidMetric(prometheus.NewDesc("snmp_error", "Error scraping target", nil, moduleLabel), err)

diff --git a/main.go b/main.go
@@ -267,6 +267,13 @@ func main() {
 				Help:      "Number of SNMP packet retries.",
 			},
 		),
+		SNMPInflight: promauto.NewGauge(
+			prometheus.GaugeOpts{
+				Namespace: namespace,
+				Name:      "request_in_flight",
+				Help:      "Current number of SNMP scrapes being requested.",
+			},
+		),
 	}
 
 	http.Handle(*metricsPath, promhttp.Handler()) // Normal metrics endpoint for SNMP exporter itself.