Use workspace versions of ember-math-helpers, remove docfy #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieTheWagner
force-pushed
the
use-workspace-versions
branch
from
61fc907 to
4efe07f
Compare
.github/workflows/ci.yml
Outdated
| - uses: actions/checkout@v4 | ||
| - name: Install Node | ||
| uses: actions/setup-node@v3 | ||
| with: |
There was a problem hiding this comment.
No need to specify node version
.github/workflows/ci.yml
Outdated
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 20.x | ||
| - uses: pnpm/action-setup@v2 |
package.json
Outdated
There was a problem hiding this comment.
In this file you may want something like this to account for nested dependencies:
| node-version: 20.x | ||
| - uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: 9 |
There was a problem hiding this comment.
No need to specify this if the package.json#packageManager field is set
docs/package.json
Outdated
| @@ -73,8 +65,8 @@ | |||
| "ember-resolver": "^13.1.0", | |||
| "ember-source": "~6.0.1", | |||
There was a problem hiding this comment.
This is where v6 is coming from.
I forgot you had another app in here
Leaving this at v6 is incompatible with the public hoist pattern, so i think that may need to go, or the ci would need to also install ember-source for this app as well during each scenario
RobbieTheWagner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.