Type declarations and template registry for Glint #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
BoussonKarel
changed the title
|
@BoussonKarel thanks for taking this on! I am curious, why not make the helper files TS instead of using declaration files? I would rather have the actual code typed, I think. |
|
Didn't feel like converting to TS 😅
But when converting to TS you can easily copy the signatures I wrote now.
…On Thu, 2 Nov 2023, 12:54 Robbie Wagner, ***@***.***> wrote:
@BoussonKarel <https://github.com/BoussonKarel> thanks for taking this
on! I am curious, why not make the helper files TS instead of using
declaration files? I would rather have the actual code typed, I think.
—
Reply to this email directly, view it on GitHub
<#1162 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANKK74OPKYFB5775PPK7VZDYCOCWTAVCNFSM6AAAAAA62PCS7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQGU4TAOBZGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@BoussonKarel I actually have a need to use ember-math-helpers in my current app for work, which uses glint, so I will open a new PR with full TS conversion shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.