Add fullscreen functionality #653
Conversation
| const window = await browser.windows.get(sender.tab.windowId); | ||
|
|
||
| await browser.windows.update(sender.tab.windowId, { | ||
| state: 'fullscreen' | ||
| }); | ||
| // confirm success | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Please have a look at the MaximizeWindow command implementation.
If the window is already in fullscreen mode the function should not return true.
| }, | ||
| { | ||
| "command": "Fullscreen", | ||
| "group": "window" |
There was a problem hiding this comment.
The command is better suited for the window.controls group.
| @@ -493,6 +493,10 @@ | |||
| "message": "New private window", | |||
| "description": "New private window" | |||
| }, | |||
| "commandLabelFullscreen": { | |||
There was a problem hiding this comment.
Please rename the command and all it's occurrences from Fullscreen to EnterFullscreen or "Enter full screen" respectively.
| @@ -723,7 +723,7 @@ export async function ToggleWindowSize (sender, data) { | |||
| // maximizes the window if it is already in full screen mode | |||
| export async function ToggleFullscreen (sender, data) { | |||
| const window = await browser.windows.get(sender.tab.windowId); | |||
|
|
|||
There was a problem hiding this comment.
Please remove unnecessary indents.
| "message": "Sets the window to its full size.", | ||
| "description": "Sets the window to its full size." |
There was a problem hiding this comment.
Please change the description to: "Activates full screen mode for the current window." The main reason for this change is that "full size" might be misunderstood as "maximize the window"
|
added another pull request with fixes and updates. thanks for the instructions. |
When you head to the Gesturefy settings>Extras and set these settings up:
wheel gesture = 'On'
wheel gesture mouse button = 'right'
wheel up = 'Toggle full screen'
wheel down = 'Toggle full screen'
Afterwards whenever you hold down the right click and scroll up, you repeatedly toggle the full screen up and down because you usually scroll the wheel rather than rolling it just as much as a single upward movement. Thus you usually get back to the screen size that you were already using and the window size is not properly toggled yet. that can be solved if we have a single "Full Screen" option which sets the window to full screen. then we can set the Gesturefy settings>Extras like this:
wheel gesture = 'On'
wheel gesture mouse button = 'right'
wheel up = 'full screen'
wheel down = 'Maximize window'
now you'll never face that problem ever again.