Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Open link in new tab doesn't work with image links #427

Closed
ZaPPZion opened this issue Oct 26, 2019 · 4 comments
Closed

[bug] Open link in new tab doesn't work with image links #427

ZaPPZion opened this issue Oct 26, 2019 · 4 comments
Milestone

Comments

@ZaPPZion
Copy link

I'm not sure if this has always been the case, but lately I've been noticing that if I use the "Open link in new tab" gesture over images (starting on the image actually) that are links (specifically on for example youtube), the links are not opened, but a new tab is opened. The gesture works fine if I'm starting from the text below the image.

OS: win10
Firefox version: 70.0 (64-bits)
Gesturefy 2.1.3

@Robbendebiene
Copy link
Owner

Robbendebiene commented Oct 28, 2019

So far I was only able to reproduce the issue on youtube thumbnails.

Update: It looks like this is because the target element of the gesture gets removed after you move your mouse away from the element by some youtube javascript.

@Robbendebiene
Copy link
Owner

I may implement a fallback for this.

@ZaPPZion
Copy link
Author

Wow, yea, youtube is indeed the problem. If I just use the gesture and stay within the image bounds, it's no issue indeed. The gesture used to work fine, just an occasional (1 in 50 or so) miss, but that might be user-error or just the browser not being fast enough and the mouse already leaving, so that wasn't an issue. But it's def youtube javascript causing this indeed. Odd choice to remove a link from an image if there's no mouse present.

@Robbendebiene Robbendebiene added this to the 3.0.0 milestone Dec 2, 2019
Robbendebiene added a commit that referenced this issue Apr 20, 2020
- reverted coordinates back to clientX/Y / css screen pixels
- the popup command menu does now scale with the page zoom for consistency and code simplicity
@Robbendebiene
Copy link
Owner

This bug is fixed with the release of Gesturefy version 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants