Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#61 use Module.canvas #85

Merged
merged 1 commit into from
Nov 24, 2023
Merged

#61 use Module.canvas #85

merged 1 commit into from
Nov 24, 2023

Conversation

konsumer
Copy link
Contributor

@konsumer konsumer commented Nov 23, 2023

This makes it so multiple instances can work in a single page, by using Module.canvas instead of canvas.

Related:

Additionally, if I am not using the plain ES5 emscritpen stuff, I have to do this before initializing to register it as a global:

window.canvas = canvas

This PR makes this unneeded (and prevents an async race-condition)

@RobLoach RobLoach merged commit 79c4566 into RobLoach:master Nov 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants