Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't follow GTK theme - dark theme is not supported #63

Open
husam212 opened this issue Nov 13, 2019 · 2 comments
Open

Doesn't follow GTK theme - dark theme is not supported #63

husam212 opened this issue Nov 13, 2019 · 2 comments

Comments

@husam212
Copy link

The look of the pop-up doesn't follow GTK theme used.

default

open-in-browser
@hackel
Copy link

hackel commented Jun 25, 2020

It doesn't need to follow the GTK theme necessarily, but should at least respect the cross-platform dark/light theme preference.

@Rob--W
Copy link
Owner

Rob--W commented Jun 25, 2020

I welcome a dark theme, possibly automatically via https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme (overridable by a preference).

@Rob--W Rob--W changed the title Doesn't follow GTK theme Doesn't follow GTK theme - dark theme is not supported Jun 25, 2020
stanio added a commit to stanio/open-in-browser that referenced this issue Dec 7, 2022
@stanio
Follow browser's light/dark theme style
8526534 
-   https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme
-   https://w3c.github.io/csswg-drafts/css-color-adjust/#color-scheme-prop

>   The ‘color-scheme’ property allows an element to indicate which color
>   schemes it is designed to be rendered with. These values are negotiated
>   with the user’s preferences, resulting in a used color scheme that
>   affects things such as the default colors of form controls and
>   scrollbars as well as the used values of the CSS system colors.

Ref: Rob--W#63
@stanio stanio mentioned this issue Dec 7, 2022
Open
stanio added a commit to stanio/open-in-browser that referenced this issue Jul 28, 2024
@stanio
Follow browser's light/dark theme style
7433364 
-   https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name
-   https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme
-   https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/light-dark

Fixes Rob--W#63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hackel @Rob--W @husam212