-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add-on pop-ups without clicking download #14
Comments
This is because the server does not send a type. Normally Firefox will
sniff the type and then either display the content inline, or download it.
To not have those dialogs, select the top option ("Open with Firefox
(Choose other application") and then it is up to Firefox how to view/open
it. You can choose to remember the choice to always do this in the future
(and if you want otherwise reset the preference at the Preferences page).
This issue can be fixed automatically if #5 is implemented.
|
Thanks for the prompt reply. Although, #5 will great improve the out-of-the-box behavior. |
Just wondering, isn't it possible (without #5) to preset this workaround on add-on installation? |
The issue is that without a MIME type, the extension does not know whether a dialog should be shown. |
The site from #14 appears to respond without Content-Type header, and `Content-Length: 0`.
This is a general solution to #14 for cases where the type is uncertain, but most likely not dialog-worthy.
To improve the UX when the dialog is shown when it should not, e.g. in #14.
I published 2.1 with the above fixes. Please try again without the preference and see if you still encounter unwanted dialogs while browsing. |
The 2.1 version improved a lot the out-of-the-box experience - only 1 pop-up after hours of browsing. Great work! |
Do you recall the circumstances under which that had happened? If you do then I can investigate it and try and fine-tune the checks even more. |
The just released WE version of this great add-on opens several pop-ups without clicking download or any other interaction from me.
It looks like some ads related urls.
Open in Browser 2.0
Firefox 57
Kubuntu 17.10 64bit
The text was updated successfully, but these errors were encountered: