Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-on pop-ups without clicking download #14

Open
bdcomp opened this issue Nov 15, 2017 · 7 comments
Open

Add-on pop-ups without clicking download #14

bdcomp opened this issue Nov 15, 2017 · 7 comments

Comments

@bdcomp
Copy link

bdcomp commented Nov 15, 2017

The just released WE version of this great add-on opens several pop-ups without clicking download or any other interaction from me.
It looks like some ads related urls.

openinbrowser

Open in Browser 2.0
Firefox 57
Kubuntu 17.10 64bit

@Rob--W
Copy link
Owner

Rob--W commented Nov 15, 2017 via email

@bdcomp
Copy link
Author

bdcomp commented Nov 15, 2017

Thanks for the prompt reply.
This workaround works, so far.

Although, #5 will great improve the out-of-the-box behavior.

@bdcomp bdcomp closed this as completed Nov 15, 2017
@bdcomp
Copy link
Author

bdcomp commented Nov 15, 2017

Just wondering, isn't it possible (without #5) to preset this workaround on add-on installation?

@Rob--W
Copy link
Owner

Rob--W commented Nov 15, 2017

The issue is that without a MIME type, the extension does not know whether a dialog should be shown.
For your specific case I have found another work-around, which I will push with the next update.

@Rob--W Rob--W reopened this Nov 15, 2017
Rob--W added a commit that referenced this issue Nov 15, 2017
The site from #14 appears to respond without Content-Type header,
and `Content-Length: 0`.
Rob--W added a commit that referenced this issue Nov 15, 2017
This is a general solution to #14 for cases where the type is
uncertain, but most likely not dialog-worthy.
Rob--W added a commit that referenced this issue Nov 15, 2017
To improve the UX when the dialog is shown when it should not, e.g. in #14.
@Rob--W
Copy link
Owner

Rob--W commented Nov 15, 2017

I published 2.1 with the above fixes. Please try again without the preference and see if you still encounter unwanted dialogs while browsing.

@bdcomp
Copy link
Author

bdcomp commented Nov 16, 2017

The 2.1 version improved a lot the out-of-the-box experience - only 1 pop-up after hours of browsing.
It's similar to the description's screenshot, just (1 kb) in the "which is" line.

Great work!

@Rob--W
Copy link
Owner

Rob--W commented Nov 16, 2017

Do you recall the circumstances under which that had happened? If you do then I can investigate it and try and fine-tune the checks even more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants