PHP 8 compatibility

[ondrejmirtes]

I already did most of these steps in my fork because I want PHPStan to be ready for PHP 8 on day one or sonner.

This is what needs to be done in BetterReflection in order to fully support PHP 8:

• Adapter signatures compatibility (ondrejmirtes@0acd452)
• mixed type (ondrejmirtes@fabd259)
• static type (ondrejmirtes@e6f9b72)
• Reflecting union types (ondrejmirtes@ce858eb - this commit needs to be broken up because it mixes more things)
• ReflectionType::__toString breaking change in PHP 8 - nullable type includes ? again (https://3v4l.org/CmTA1)
• ReflectionSourceStubber misses to generate return types (ondrejmirtes@6a87721)
• isBuiltin() is supposed to be only on ReflectionNamedType in PHP 8 (ondrejmirtes@86c5ce7)
• Stringable (ondrejmirtes@e9f99da)
• PhpStormStubsSourceStubberTest will fail a lot when building on PHP 8 because a lot of stuff changed between PHP 8 and PHP 7
• Promoted properties in constructor - I plan to solve this by making ReflectionProperty an interface with two implementations - one based on Property node, the other based on Param node.
• Only __construct methods can be considered constructors
• Support for reading Attributes
• Constant of value null as a default parameter value no longer makes the parameter type nullable

The Stringable commit and the obsoleted old-style constructors require an if based on the PHP version. I did that with a public static property on BetterReflection but a different way can be fine too.

Some of these items require a new major version, but some of them can be done in a minor version before that.

I'm creating this issue because I plan to send PRs for these (in case someone isn't faster than me) but I'd like to hear your opinions first :)

[Ocramius]

I'm creating this issue because I plan to send PRs for these (in case someone isn't faster than me) but I'd like to hear your opinions first :)

I mean, PHP 8 support is certainly to be added, but no work has been done here so far because we're all quite busy with other work at the moment, so I would expect us to be somewhere close to compliance in January or such :D

If the patches are QA'd properly (reads: tests + acceptable MT) and made separate, they are very welcome! 👍

[limingxinleo]

PHP8.0 was released.

[ghost]

please support PHP8, thanks

[Ocramius]

As I mentioned above:

so I would expect us to be somewhere close to compliance in January or such :D

If you want to help out, send patches for the bullet points that @ondrejmirtes wrote above

[Ocramius]

Marking this issue as a blocker for 4.12.0 - we'll try getting PHP 8 support in that version.

[huangzhhui]

Marking this issue as a blocker for 4.12.0 - we'll try getting PHP 8 support in that version.

I notice that 4.12.0 has been released in 16 days ago, any progress about PHP 8 compatibility ?

[Ocramius]

@huangzhhui nay: busy with other work, but please send patches, if you can help out.

[DanielBadura]

I think the result we are aiming here is to support ^7.4 and ^8.0 or do we want to drop 7.4 support?
Im asking because of the ::export method from ReflectionClass, ReflectionFunction etc. got dropped in 8.0 and this would result in big if/else on PHP_VERSION_ID i suppose.

[Ocramius]

@DanielBadura at first ^7.4 || ~8.0.0, and after that only ~8.0.0 in a new minor release: that allows upgrading easily.

[lisachenko]

Hello, gentlemen! Are there any ETA on when PHP8 will be supported by BR? @ondrejmirtes maybe you can work on this? Unfortunately, I don't have too much time now to maintain my libraries and goaop/parser-reflection is one of them which can be replaced with BR, but if BR won't have PHP8 support soon, I might opt to keep supporting it...

[Ocramius]

On my end, I had almost zero time for OSS since December: trying to mostly fit it when something work-related requires intervention. The whole COVID situation is a massive deterrent to invest more time than necessary in OSS, and it will likely stay like this until I'm free to leave my home again, or else the net result will be a clear computer-related burnout 😩 Any help in improving the lib is very welcome, and I'll certainly react to any patches sent (review/merges).

…

On Sat, Mar 27, 2021, 14:03 Alexander Lisachenko ***@***.***> wrote: Hello, gentlemen! Are there any ETA on when PHP8 will be supported by BR? @ondrejmirtes <https://github.com/ondrejmirtes> maybe you can work on this? Unfortunately, I don't have too much time now to maintain my libraries and goaop/parser-reflection is one of them which can be replaced with BR, but if BR won't have PHP8 support soon, I might opt to keep supporting it... — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#701 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABFVEFAM6NV46ZWM6TR3JTTFXJTFANCNFSM4TEYLPDQ> .

[lisachenko]

Thank you @Ocramius! I can completely understand this, no worries.

It is very important to prevent OSS burn out, especially for you, as half of most popular PHP libraries were invented/developed by you, so want just to say thank you for working on all of them 👍

It's a spring time, so relax a little bit, drink your favourite beer, prepare a BBQ and of course, stay healthy!

PS. There are small chances that I'll have some time for OSS, but want to work more on my own libraries and laminas-code package a little bit, preparing changes for the next major version for your review.

[WyriHaximus]

@kukulich Ok awesome, then let you get that in first before we divide and conquer. Unless there is something I can already start on. Have time reserved for this tomorrow so I'll also get familiar with the code and the changes Ondřej did.

[kukulich]

@WyriHaximus I think you can try anything based on my branch. I will try to make the build green as a start.

[WyriHaximus]

@kukulich Cool, starting with ReflectionNamedType::isBuiltin

[WyriHaximus]

Now that I'm working on it, will probably do the named and union type changes in one go for reflection type

[WyriHaximus]

@kukulich Build #752 on your work, probably have to rebase it when you're done

[kukulich]

These are fixed/implemented in #750 and #752 :

• Reflecting union types
• ReflectionType::__toString breaking change in PHP 8
• ReflectionSourceStubber misses to generate return types
• isBuiltin() is supposed to be only on ReflectionNamedType
• PhpStormStubsSourceStubberTest will fail a lot
• Constant of value null as a default parameter value no longer makes the parameter type nullable

[kukulich]

#759

• Only __construct methods can be considered constructors

[kukulich]

Stringable: #770

[kukulich]

@WyriHaximus Btw I'll try Promoted properties in constructor as next.

[WyriHaximus]

@kukulich Came across that in a few places already <3

[Ocramius]

I think we're only missing:

• promoted properties
• attributes

Then we're probably ready to go with 8.0

[kukulich]

Promoted properties: #785

[kukulich]

Attributes: #787

[WyriHaximus]

@Ocramius @kukulich Sorry got side tracked for a few days, is there anything besides attributes that needs to be done?

[kukulich]

@WyriHaximus Nope, PHP 8 is “done”. You can try to do something in PHP 8.1 - eg. intersection types :)

[WyriHaximus]

@kukulich Looks like a royal pain in the ass, I'm on it

[kukulich]

@WyriHaximus you can start here: #767

[WyriHaximus]

@kukulich Cool will rebase it off that one later. So far it looks very similar to the work I've done on the named and union types so this could be a lot easier than I thought.

[WyriHaximus]

@Ocramius @kukulich Was just looking at ReflectionUnionType and AFAIK union types can't be nested, noir does that make sense. Then shouldn't we just filter out the ReflectionNamedTypes like this? WyriHaximus-labs@356777b#diff-7a5518cccd601dbefec3f22042c8486f69b20ebd3fccabc87bf0f44b9c2cbedf

[Ocramius]

#787 is the last bit missing here, but beware that we will only support php:^8.0.12 onwards.

[Ocramius]

Closing here: we'll probably still finish up PHP 8.1 support before releasing, but all the topics in here are pretty much exhausted 👍

[ondrejmirtes]

Thank you, I'm really happy about this 😊 I'm probably gonna have to devote November and December to bringing PHP 8.1 support into PHPStan, and this is gonna help me a lot 😊