Fixing issue 409 #410
Merged
Fixing issue 409 #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to deserialize a 32-bit bitmap. It would usually work, but sometimes it would fail (see #409) because the number of containers would be recognized as a cookie. This PR just disables this attempt at supporting 32-bit bitmaps loading from 64-bit bitmaps.
wjohnson-aurora
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
I can confirm that commit 94aeb2b fixes issue #409. Thank you!
|
I am going to merge. This can be partially reverted if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deserializing a 64-bit roaring bitmap, the code would first try to deserialize a 32-bit bitmap. It would usually work, but sometimes it would fail (see #409) because the number of containers would be recognized as a cookie.
This PR disables this attempt at supporting 32-bit bitmaps loading from 64-bit bitmaps.
To compensate the reduction in functionality, the PR adds
Roaring32AsRoaring64: users that have 32-bit bitmaps that they want to load as 64-bit bitmaps can just load them as 32-bit bitmaps and them callRoaring32AsRoaring64to wrap them so that they appear as 64-bit bitmaps.I do not include a test for issue 409 because it requires a non-trivial amount of memory to trigger it and I am concerned about stress on our CI.