Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer allocate temporary memory when serializing #247

Merged
merged 1 commit into from
Mar 29, 2020
Merged

No longer allocate temporary memory when serializing #247

merged 1 commit into from
Mar 29, 2020

Conversation

lemire
Copy link
Member

@lemire lemire commented Mar 27, 2020

This might be faster than another PR:

#246

@lemire lemire requested a review from alldroll March 27, 2020 16:36
@lemire lemire mentioned this pull request Mar 27, 2020
Closed
alldroll
alldroll approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@alldroll alldroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Simple and elegant

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 82.253% when pulling d53779d on dlemire/fastertobytes into 4d53b29 on master.

@kevinconaway
Copy link
Contributor

I will try this out on our workload and report back, thank you!

@lemire
Copy link
Member Author

lemire commented Mar 27, 2020

@kevinconaway Please do.

@kevinconaway
Copy link
Contributor

@lemire I tested this out and it works great. Thank you so much! I will close my other PR

@alldroll alldroll merged commit 239247b into master Mar 29, 2020
@lemire
Copy link
Member Author

lemire commented Mar 29, 2020

Tagged as a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alldroll alldroll alldroll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lemire @coveralls @kevinconaway @alldroll