-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serde support #226
Add serde support #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add tests that serialize, deserialize and check equality, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, LGTM!
bors merge
226: Add serde support r=Kerollmops a=irevoire Add support for serde to make our serialize function easier to use. Co-authored-by: Irevoire <[email protected]> Co-authored-by: Tamo <[email protected]>
Build failed: |
What the heck: operation was canceled.... |
226: Add serde support r=Kerollmops a=irevoire Add support for serde to make our serialize function easier to use. Co-authored-by: Irevoire <[email protected]> Co-authored-by: Tamo <[email protected]>
Build failed: |
bors merge |
226: Add serde support r=Kerollmops a=irevoire Add support for serde to make our serialize function easier to use. Co-authored-by: Irevoire <[email protected]> Co-authored-by: Tamo <[email protected]>
Build failed: |
Now that we fixed the bug on main, we can try again! |
Build succeeded: |
Add support for serde to make our serialize function easier to use.