fix(operator): truncate sidecar pod injected label to 63 chars

Refs: open-telemetry#1032
RoVernekar · Oct 19, 2023 · 59c4cc4 · 59c4cc4
1 parent 41295b4
commit 59c4cc4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/pkg/sidecar/pod.go b/pkg/sidecar/pod.go
@@ -53,7 +53,7 @@ func add(cfg config.Config, logger logr.Logger, otelcol v1alpha1.OpenTelemetryCo
 	if pod.Labels == nil {
 		pod.Labels = map[string]string{}
 	}
-	pod.Labels[label] = fmt.Sprintf("%s.%s", otelcol.Namespace, otelcol.Name)
+	pod.Labels[label] = naming.Truncate("%s.%s", 63, otelcol.Namespace, otelcol.Name)
 
 	return pod, nil
 }

diff --git a/pkg/sidecar/pod_test.go b/pkg/sidecar/pod_test.go
@@ -48,7 +48,7 @@ func TestAddSidecarWhenNoSidecarExists(t *testing.T) {
 	}
 	otelcol := v1alpha1.OpenTelemetryCollector{
 		ObjectMeta: metav1.ObjectMeta{
-			Name:      "otelcol-sample",
+			Name:      "otelcol-sample-with-a-name-that-is-longer-than-sixty-three-characters",
 			Namespace: "some-app",
 		},
 		Spec: v1alpha1.OpenTelemetryCollectorSpec{
@@ -74,7 +74,8 @@ processors:
 	require.Len(t, changed.Spec.Containers, 2)
 	require.Len(t, changed.Spec.InitContainers, 2)
 	require.Len(t, changed.Spec.Volumes, 1)
-	assert.Equal(t, "some-app.otelcol-sample", changed.Labels["sidecar.opentelemetry.io/injected"])
+	assert.Equal(t, "otelcol-sample-with-a-name-that-is-longer-than-sixty-three-cha",
+		changed.Labels["sidecar.opentelemetry.io/injected"])
 	assert.Equal(t, corev1.Container{
 		Name:  "otc-container",
 		Image: "some-default-image",