thunderbolt: Fix memory leak in margining_port_remove()

The dentry returned by debugfs_lookup() needs to be released by calling dput() which is missing in margining_port_remove(). Fix this by calling debugfs_lookup_and_remove() that combines both and avoids the memory leak. Fixes: d0f1e0c ("thunderbolt: Add support for receiver lane margining") Cc: [email protected] Signed-off-by: Yaxiong Tian <[email protected]> Signed-off-by: Mika Westerberg <[email protected]>
RoPieee · Nov 27, 2023 · ac43c91 · ac43c91
1 parent 2cc14f5
commit ac43c91
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/thunderbolt/debugfs.c b/drivers/thunderbolt/debugfs.c
@@ -959,7 +959,7 @@ static void margining_port_remove(struct tb_port *port)
 	snprintf(dir_name, sizeof(dir_name), "port%d", port->port);
 	parent = debugfs_lookup(dir_name, port->sw->debugfs_dir);
 	if (parent)
-		debugfs_remove_recursive(debugfs_lookup("margining", parent));
+		debugfs_lookup_and_remove("margining", parent);
 
 	kfree(port->usb4->margining);
 	port->usb4->margining = NULL;