cses problem url support added #55
Conversation
done ... |
|
@MarufSharifi do you mind reviewing this PR and seeing if the changes make sense? |
There was a problem hiding this comment.
Please consider a new candition in the CodeForces.tsx for cses.fi as well.
<div> {hostname === "codeforces.com" ? ( <div className={"codeforces"} ref={MathRef}> {parse(htmlString)} </div> ) : ( <div className={"atcoder"} ref={MathRef}> {parse(htmlString)} </div> )} <Divider /> </div>
| (function () { | ||
| var script = document.createElement("script"); | ||
| script.type = "text/javascript"; | ||
| script.src = "https://cses.fi/lib/MathJax/MathJax.js?config=TeX-AMS-MML_HTMLorMML"; // use the location of your MathJax | ||
|
|
||
| var config = 'MathJax.Hub.Config({' + | ||
| 'extensions: ["tex2jax.js"],' + | ||
| 'jax: ["input/TeX","output/HTML-CSS"]' + | ||
| '});' + | ||
| 'MathJax.Hub.Startup.onload();'; | ||
|
|
||
| script.text = config; | ||
|
|
||
| document.getElementsByTagName("head")[0].appendChild(script); | ||
| })(); | ||
|
|
There was a problem hiding this comment.
Please remove this function, because it will create a new script with every render,
There was a problem hiding this comment.
Thanks, I just forgot to remove my earlier code that was not working
|
|
||
|
|
There was a problem hiding this comment.
Please try to remove unwanted spaces
|
@Rishabh-malhotraa sorry sir for being late, I have made the requested changes. I think sir now you can merge it. |
please consider this changes as well |
thanks, just now I am doing sir |
| )} | ||
| ) : ""} | ||
| {hostname === "cses.fi" ? ( | ||
| <div className={"cses"} ref={MathRef}> |
There was a problem hiding this comment.
sorry, where does cses className come from?
There was a problem hiding this comment.
if problem is of cses than div will have className="cses" as it is in "atcoder" and "codeforces"?
is that you are asking for?? i didn't get you are asking for
There was a problem hiding this comment.
sorry, where does cses className come from?
You didn't select cses className, you should select that and add proper style for related element
| <div className={"codeforces"} ref={MathRef}> | ||
| {parse(htmlString)} | ||
| </div> | ||
| ) : ( | ||
| ) : ""} | ||
| {hostname === "atcoder.com" ? ( | ||
| <div className={"atcoder"} ref={MathRef}> | ||
| {parse(htmlString)} | ||
| </div> | ||
| )} | ||
| ) : ""} | ||
| {hostname === "cses.fi" ? ( | ||
| <div className={"cses"} ref={MathRef}> | ||
| {parse(htmlString)} | ||
| </div> | ||
| ) : ""} |
There was a problem hiding this comment.
Please don't separate the conditions, they are all related to each other, for better code looking change this to as it was and add new condition
from separate statements to a single statement
Rishabh-malhotraa
force-pushed
the
main
branch
14 times, most recently
from
fb409ad to
5dcd1f7
Compare
I have solved issue #52
Please review my code and merge it.
If any Improvement is needed please suggest and guide me.
thanks, I would like to work on more issues like this.