Allow artifact_file to handle snapshot and latest version correctly (V2 !) #128
Conversation
|
Target file is now renamed with provided name during the process. |
| # | ||
| # @return [Boolean] true when the coordinates's version is a snapshot. | ||
| def snapshot?(coordinates) | ||
| coordinates.split(':')[-1].include?('-SNAPSHOT') |
There was a problem hiding this comment.
I still think the interim step here is important. Assuming that the error handling is good, we should avoid this array splicing and just use
artifact = NexusCli::Artifact.new(coordinates)
aritfact.version.include?('-SNAPSHOT')
|
Roger that, I'll update this 2 tests using artifact method calls |
|
I'll verify checksuming tomorrow, retest and fix if needed. (It was OK when i tested this so far .. But I could have missed something) |
|
updated. |
|
This looks good for now, though I do agree that the TYVM for the contribution! |
Allow artifact_file to handle snapshot and latest version correctly (V2 !)
|
Works Here! Got an ETA on the next release ? |
Hi !
I've cleaned up my previous PR and I have taken into account the comments and requests.
I successfully tested many update/upgrade/downgrade/init scenarios from Nexus.
Please test and review this work.
PS : I know some
iftests may be quite long ... Perhaps it would be interesting to simplify this into adef