Skip to content

Commit

Permalink
remove aurora theme deprecated in Framework7 v8
Browse files Browse the repository at this point in the history
  • Loading branch information
hypebright committed Mar 8, 2024
1 parent 19edbb0 commit 6bb549c
Show file tree
Hide file tree
Showing 9 changed files with 20 additions and 22 deletions.
2 changes: 2 additions & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
export("%>%")
export(addF7Popover)
export(addF7Tooltip)
export(add_framework7_deps)
export(add_shinyMobile_deps)
export(create_manifest)
export(f7Accordion)
export(f7AccordionItem)
Expand Down
4 changes: 2 additions & 2 deletions R/f7Page.R
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#' @param options shinyMobile configuration. See \url{https://framework7.io/docs/app.html}. Below are the most
#' notable options. General options:
#' \itemize{
#' \item \code{theme}: App skin: "ios", "md", "auto" or "aurora".
#' \item \code{theme}: App skin: "ios", "md", or "auto".
#' \item \code{dark}: Dark layout. TRUE or FALSE.
#' \item \code{skeletonsOnLoad}: Whether to display skeletons on load.
#' This is a preloading effect. Not compatible with preloader.
Expand Down Expand Up @@ -56,7 +56,7 @@ f7Page <- function(
title = NULL,
# default options
options = list(
theme = c("auto", "ios", "md", "aurora"),
theme = c("auto", "ios", "md"),
dark = TRUE,
skeletonsOnLoad = FALSE,
preloader = FALSE,
Expand Down
3 changes: 1 addition & 2 deletions R/f7Sheet.R
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
#' @param swipeToStep If TRUE then sheet will be opened partially,
#' and with swipe it can be further expanded.
#' @param backdrop Enables Sheet backdrop (dark semi transparent layer
#' behind). By default it is TRUE for MD and Aurora themes and
#' FALSE for iOS theme.
#' behind). By default it is true for MD theme and false for iOS theme.

This comment has been minimized.

Copy link
@DivadNojnarg

DivadNojnarg Mar 8, 2024

Member

@hypebright will require an entry in new.md for any breaking change.

This comment has been minimized.

Copy link
@hypebright

hypebright Mar 8, 2024

Author Contributor

@DivadNojnarg I'll start writing the entry in the NEWS file so we can track everything

#' @param closeByOutsideClick When enabled, sheet will be closed on
#' when click outside of it.
#' @param swipeHandler Whether to display a swipe handler. TRUE by default.
Expand Down
2 changes: 1 addition & 1 deletion inst/examples/split_layout/app.R
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ shinyApp(
ui = f7Page(
title = "Split layout",
options = list(
theme = "aurora",
theme = "auto",
dark = TRUE,
filled = FALSE,
color = "#007aff",
Expand Down
1 change: 0 additions & 1 deletion man/add_framework7_deps.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion man/add_shinyMobile_deps.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions man/f7Page.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions man/sheet.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions vignettes/shinyMobile.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ library(bslib)

## Custom skins

`{shinyMobile}` offers 3 skins:
`{shinyMobile}` offers 2 skins:

- __aurora__ for desktop apps.
- __ios__ and __md__ for mobile apps.
- __ios__
- __md__

It automatically detects if the app is running with android or iOS and accordingly adapts the layout. It is of course possible to apply the iOS skin on an android device and inversely, although not recommended.
It automatically detects if the app is running with android or iOS and accordingly adapts the layout. It will use the MD theme for all other devices. It is of course possible to apply the iOS skin on an android device and inversely, although not recommended.

`{shinyMobile}` also provides 2 themes, namely light and dark.

Expand All @@ -47,7 +47,7 @@ It automatically detects if the app is running with android or iOS and according
## UI elements
### Inputs: brief comparison side by side with `{shiny}`

`{shinyMobile}` has its own custom input widgets with unique design for each skin (iOS/android/aurora). Below we summarise all known shiny inputs and their
`{shinyMobile}` has its own custom input widgets with unique design for each skin (iOS/android). Below we summarise all known shiny inputs and their
equivalent with `{shinyMobile}`.

| Features (sample) | shiny | shinyMobile |
Expand Down Expand Up @@ -520,7 +520,7 @@ shinyApp(
ui = f7Page(
title = "My app",
options = list(
theme = "aurora",
theme = "auto",
dark = TRUE,
filled = FALSE,
color = "#007aff",
Expand Down Expand Up @@ -668,7 +668,7 @@ This is where you can customize the global app behavior:

```{r, eval=FALSE}
options = list(
theme = c("ios", "md", "auto", "aurora"),
theme = c("ios", "md", "auto"),
dark = TRUE,
filled = FALSE,
color = "#007aff",
Expand Down

0 comments on commit 6bb549c

Please sign in to comment.