Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask to enable steam integration at setup #667

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

hk21702
Copy link
Collaborator

@hk21702 hk21702 commented Oct 28, 2024

At the initial setup of an instance, display a dialog asking if the user would like to enable steam integration. The only checks for displaying this or not are if this is initial setup of this instance, and if steam integration is already on for whatever reason (for grandfathering in existing setups).

image

Internally, this introduces a new attribute at the instance level to track whenever or not this was the initial setup. At init of the object it is True, but after all setup steps in main_window, it is forced to False. The current implementation violates MVC a bit and will need to be potentially overhauled more deeply in a future refactor.

Also, improves the internals of instance's as_dict so it does not need to be manually expanded whenever a new attribute is added to instance.

@hk21702 hk21702 added Code refactoring 🧹 improving the structure and organization of the code; restructuring, cleaning up accessibility 👀 ℹ️🤓 user-friendly optimization, like notifications, warnings and action alerts labels Oct 28, 2024
@hk21702 hk21702 self-assigned this Oct 28, 2024
@hk21702
Copy link
Collaborator Author

hk21702 commented Oct 28, 2024

As a side note, I'd like feedback on whenever or not all dialog str at the text level (first main line) should be big and bold like in the screenshot for better differentiation. In the image, it is h2.

@LionelColaso
Copy link
Collaborator

As a side note, I'd like feedback on whenever or not all dialog str at the text level (first main line) should be big and bold like in the screenshot for better differentiation. In the image, it is h2.

personally not a fan of h2 but its better if its done in #57

@Limfjorden
Copy link
Contributor

I think the text should provide examples of features that require steam. I would change the text to something like

This will, among other things, allow you to use mods from the workshop by subscribing on steam as you would normally.

@hk21702
Copy link
Collaborator Author

hk21702 commented Oct 28, 2024

As a side note, I'd like feedback on whenever or not all dialog str at the text level (first main line) should be big and bold like in the screenshot for better differentiation. In the image, it is h2.

personally not a fan of h2 but its better if its done in #57

I can make it h3 instead. #57 is talking about something different and is a global scale of font size. This would only affect dialog text.

@hk21702
Copy link
Collaborator Author

hk21702 commented Oct 28, 2024

I think the text should provide examples of features that require steam. I would change the text to something like

This will, among other things, allow you to use mods from the workshop by subscribing on steam as you would normally.

image

h3 with extended details

@LionelColaso
Copy link
Collaborator

LionelColaso commented Oct 28, 2024

I can make it h3 instead. #57 is talking about something different and is a global scale of font size. This would only affect dialog text.

Use size u think looks, fits and allings better in the diag

@hk21702 hk21702 force-pushed the ask-steam-integration branch from f9a48fb to c8956c3 Compare October 28, 2024 12:08
@hk21702 hk21702 merged commit 4aa97d4 into main Oct 28, 2024
27 checks passed
@hk21702 hk21702 deleted the ask-steam-integration branch October 28, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 👀 ℹ️🤓 user-friendly optimization, like notifications, warnings and action alerts Code refactoring 🧹 improving the structure and organization of the code; restructuring, cleaning up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants