-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask to enable steam integration at setup #667
Conversation
As a side note, I'd like feedback on whenever or not all dialog str at the text level (first main line) should be big and bold like in the screenshot for better differentiation. In the image, it is h2. |
personally not a fan of h2 but its better if its done in #57 |
I think the text should provide examples of features that require steam. I would change the text to something like
|
I can make it h3 instead. #57 is talking about something different and is a global scale of font size. This would only affect dialog text. |
Use size u think looks, fits and allings better in the diag |
f9a48fb
to
c8956c3
Compare
At the initial setup of an instance, display a dialog asking if the user would like to enable steam integration. The only checks for displaying this or not are if this is initial setup of this instance, and if steam integration is already on for whatever reason (for grandfathering in existing setups).
Internally, this introduces a new attribute at the instance level to track whenever or not this was the initial setup. At init of the object it is True, but after all setup steps in main_window, it is forced to False. The current implementation violates MVC a bit and will need to be potentially overhauled more deeply in a future refactor.
Also, improves the internals of instance's
as_dict
so it does not need to be manually expanded whenever a new attribute is added toinstance
.