Plaintext votes 2 #141
Merged
Plaintext votes 2 #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isplayCardViewModel.cs as appropriate.
# Conflicts: # RightToAskClient/RightToAskClient/RightToAskClient/HttpClients/RTAClient.cs # RightToAskClient/RightToAskClient/RightToAskClient/ViewModels/ReadingPageViewModel.cs
…ch questions are already up-voted.
…odel.cs rather than Question.
…but not thoroughly tested. Also wrote Extension to exception, but not yet used.
…d and thew exception if not.
LukeMcCarthy-TW
approved these changes
Dec 13, 2022
| public class QuestionTests | ||
| { | ||
|
|
||
| /* FIXME - this test displays exactly the same unpredictable behaviour that was |
There was a problem hiding this comment.
Should we fix this test before merging?
| } | ||
|
|
||
| /* |
There was a problem hiding this comment.
We should delete this code and add a card to the back log
| private HashSet<string> _dismissedQuestionIDs; | ||
| private bool _isInitialised; | ||
|
|
||
| public void Init() |
There was a problem hiding this comment.
Indentation seems strange in this file, are the methods meant to be indented that far?
There was a problem hiding this comment.
Don't worry about this
| @@ -0,0 +1,101 @@ | |||
| using System; | |||
There was a problem hiding this comment.
Would like some more tests for this. For example try and test what happens when you try to add something in the hashset
|
corrected error that caused tests to fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a start on getting plaintext up- and down-voting to work. I also organised dismissed-votes a little better.
Up-voting only works on the QuestionDisplayCard, not on the QuestionDetailView. Down-voting is not implemented yet. On the QuestionDisplayCard, both numbers are the total number of upvotes.
Flagging is not implemented except to turn the flag red.
While testing my changes, I noticed Issue #140 . However, I don't think this PR introduces it because it was present in main already.