Support filename downloads with special characters #4097
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileResponse enhancments
This commit fixes an issue with the fileResponse when the fileName contains special characters (such as Umlaute).
To support special characters in a filename in asp.net, one can use the ContentDisposition.FileNameStar property (instead of FileName). Example in the C# code below:
Regarding the regex, please have a look at:
(regex used from a comment of the accepted answer since the accepted answer did have some issues. Tested quite well)
Remark: this PR is related to pull request 3867 which in its first version did not support the case when the server sent a filename with special characters but also a filename without it. This version first uses the filename with special characters and the one without as fallback (same behavior as Mozilla Firefox). See also the discussion in #3867