Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] VersionedApiExplorer example #1752

Conversation

LuukN2
Copy link

@LuukN2 LuukN2 commented Nov 19, 2018

A W.I.P. generator for WebApi and WebApi with OData using the VersionedApiExplorer.

No generator is necessary for AspNetCore because versioning replaces the interfaces used by the Mvc Apiexplorer.

@RicoSuter RicoSuter changed the title VersionedApiExplorer example [WIP] VersionedApiExplorer example Nov 20, 2018
@RicoSuter
Copy link
Owner

Thanks for the PR. I personally don't support (legacy) ASP.NET Web API anymore and fully concentrate on ASP.NET Core... but if this feature just requires these two projects (which are independent and tested) then i can merge and just release them too...

@LuukN2
Copy link
Author

LuukN2 commented Nov 20, 2018

Awesome, I'll finish the processors and make a test project. I will try to help out at versioning to get the ODataQueryableAttributes supported so an odata specific processor will not be necessary here.

Should I move over the files from NSwag.AspNet.Owin over to the new project since it keeps a reference to NSwag.SwaggerGeneration.WebApi?

@RicoSuter
Copy link
Owner

RicoSuter commented Nov 20, 2018

Should I move over the files from NSwag.AspNet.Owin over to the new project since it keeps a reference to NSwag.SwaggerGeneration.WebApi?

No, that's fine. The new projects can use existing ones... It would be great if you don't change existing projects - and if you do please keep them minimal and comment why you did it...

@LuukN2
Copy link
Author

LuukN2 commented Jan 10, 2019

I added some tests and it seems to work in my production environment. I made no changes to any of the existing projects.

@RicoSuter
Copy link
Owner

Whats the state of this pr?

@RicoSuter
Copy link
Owner

TBH, is it really work investing more time in the legacy ASP.NET MVC support (pre .NET Core)? There the generator is reflection based and bad anyway...

@LuukN2
Copy link
Author

LuukN2 commented May 20, 2019

Currently this will support Web Api and odata using the versioned api explorers, I don't know how many people would need support for the old Mvc.

Supporting OData and Web Api on .NET framework with the latest packages is important for us. I'm not quite sure how many other have this requirement, especially with old mvc which doesn't have an api explorer.

I'd say it should be fine to support only Web Api and OData since the api explorers should make it relatively low effort to maintain when things update.

@RicoSuter
Copy link
Owner

Ok, yes - it's a completely new library and should not interfere something else... there will be some breaking changes soon (v13): #2178

We might need to fix some things in the PR then...

@RicoSuter
Copy link
Owner

Will not continue to support legacy technologies (full .net, asp.net etc)

@RicoSuter RicoSuter closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants