Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# Client - Add CancellationToken parameter to PrepareRequestAsync #3919

Closed
crackalak opened this issue Mar 3, 2022 · 1 comment · Fixed by #3932
Closed

C# Client - Add CancellationToken parameter to PrepareRequestAsync #3919

crackalak opened this issue Mar 3, 2022 · 1 comment · Fixed by #3932

Comments

@crackalak
Copy link
Contributor

When GeneratePrepareRequestAndProcessResponseAsAsyncMethods is enabled, PrepareRequestAsync and ProcessResponseAsync methods are generated, but only ProcessResponseAsync is passed the cancellation token.

NSwag/src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.liquid

Line 286 in 67cc25b

await PrepareRequestAsync(client_, request_, urlBuilder_).ConfigureAwait(false);

NSwag/src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.liquid

Line 295 in 67cc25b

await PrepareRequestAsync(client_, request_, url_).ConfigureAwait(false);

NSwag/src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.liquid

Line 313 in 67cc25b

await ProcessResponseAsync(client_, response_, cancellationToken).ConfigureAwait(false);

@RicoSuter
Copy link
Owner

This seems wrong (dont see a reason why not to add it in all three).
Can you maybe create a PR to fix this?

crackalak added a commit to crackalak/NSwag that referenced this issue Mar 13, 2022
@crackalak
Fixed missing cancellation token parameters in C# client
c7334a3 
Fixes RicoSuter#3919
@crackalak crackalak mentioned this issue Mar 13, 2022
Merged
RicoSuter pushed a commit that referenced this issue May 18, 2022
@crackalak
Fixed missing cancellation token parameters in C# client (#3932)
0b19353 
Fixes #3919
lahma pushed a commit to lahma/NSwag that referenced this issue Dec 25, 2022
@crackalak @lahma
Fixed missing cancellation token parameters in C# client (RicoSuter#3932
b135283 
)

Fixes RicoSuter#3919
lahma pushed a commit to lahma/NSwag that referenced this issue Jan 20, 2024
@crackalak @lahma
Fixed missing cancellation token parameters in C# client (RicoSuter#3932
7adaca8 
)

Fixes RicoSuter#3919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed missing cancellation token parameters in C# client crackalak/NSwag
2 participants
@RicoSuter @crackalak