-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Countdown #2
base: master
Are you sure you want to change the base?
Countdown #2
Conversation
Added semicolon at end of line 3
corrected missing semicolon
Ian, it wouldn't let me merge, so I uploaded to my host, did some tweaks and added to main version. |
It's looking good! I messed about with my local git repository, then deleted it and did a new git clone from KingstonMakerLabs. So I probably screwed up the system, as the original stuff from me was gone by then. I'm a newcomer to git, and need to learn more. This is a perfect opportunity. |
We'll stick with GitHub for now until we understand it better. Another option is email me the code & I can add/amend the main copy. One thing I noticed last night (although I was tired) you had forked you Also I will remove the full stop at end of each line. Anyway it's working for now, so all good. Paul On Thursday, 19 December 2013, woodscooter wrote:
|
Another thought, maybe we could make a little fancier by using php image Obviously need code working nicely, but something's we could do include Paul. Sent from my iPhone On 19 Dec 2013, at 10:03, woodscooter [email protected] wrote: It's looking good! I messed about with my local git repository, then I'm a newcomer to git, and need to learn more. This is a perfect — |
Yes, could include images. Probably most easily done by controlling the layout in HTML, with php providing the variable text here and there as needed. Would an image be the same across all sorts of devices, from computer screen browsers, through smaller tablets, down to small smartphones? Or maybe the image would need to be selected according to the display device. It's up for discussion. |
OK, was thinking again (I know it's dangerous), what if the text displayed was done identically to the bus stop real displays? I was thinking that there is only a fixed amount of space on them eg 15 chars for destination. This would make it more like a real one if we used a fixed width font as well. ( - = Spaces below) 1-371--Richmond--------1 min |
That format is what people are used to seeing, so our display will be best understood if we conform to it too. I will fiddle with the PHP on github to change the layout. I will leave any font change to you -though I'm quite happy with Tahoma, as it is. When I'm done, if you are unable to approve my pull request, perhaps you could make woodscooter a Member of KingstonMakerLabs on Github, then I can edit the code direct. |
I take you used git before? How do I add projects to the main kml project? woodscooter [email protected] escribió:
Enviado desde mi teléfono con K-9 Mail. |
Thanks Paul G for adding me to this repo. I think Andreas wants access next! I have modified one line of the PHP to tidy up display for more than 9 lines. Please try it out. Unable to "git push" from my terminal. I get a very complicated error message. Will understand eventually, but for now I can edit the master via the git website, so that's OK with me. |
I can add Andres (i think he's amunizp but want it confirmed first). I the folder for the buscoded.php I have the bus_stops.json file from another project on GitHub. Rather than hard coding the "Ashburnham Road" name, it might be worth reading from that file so it stop names are changed (hey I've already setup one for myself to test in mornings), it still works 100%. I've also figured out and made 1 minor change myself (-15 to -16) to the Destination length. See http://www.kml.dreamhosters.com/bus/eden.php |
Yes amunizp is me! I would like to add other projects to the kml group. The only error I got was a case of mistaken identity. But that now works by setting same user on command line as the webpage. Git told me what to do. Thanks! M0TZO [email protected] escribió:
Enviado desde mi teléfono con K-9 Mail. |
Corrected the semicolon error, added HTML tags, created auto-refresh (every 32 s). Please merge.