Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the JSON spec, anything except "\ and the control characters can go in the string, the only characters we want to escape in addition would be
<
,\u2028
and\u2029
for HTML embedding (unless I'm missing something).Instead of building up strings character by,
and the object key hashmap key seems to be 25% ish slower than the switch version, this does introduce some duplication but it should only be on the server side, will try to consolidate both at some point.
Results:
I modified the seroval benchmark to compare stringify/parse results instead of uneval/eval and sprinkled in some control characters in some of the strings. The first line in each is the previous version, and the second line is with this PR.