Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: base paint flow #9

Merged
merged 23 commits into from
May 14, 2020
Merged

feat: base paint flow #9

merged 23 commits into from
May 14, 2020

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented Apr 22, 2020 •
edited
Loading

A cross platform canvas. Basic 2d support now.

@mergify
Copy link
Contributor

mergify bot commented Apr 22, 2020

Clippy help us to improve our Rust code. Could you fix it? 🙏 Run cargo clippy --all-targets --all-features -- -D warnings to get more details.

M-Adoo added 16 commits April 23, 2020 23:49
@M-Adoo
feat: add a example
da083a2
@M-Adoo
feat: init commit for canvas
cb252d4
@M-Adoo
feat: 2d layer framework code
b98b93d
@M-Adoo
feat: merge layer
af0aa5f
@M-Adoo
feat: base shaders for canvas
0d50e3e
@M-Adoo
feat: impl smae type 2d buffer iterator
0f06fe3
@M-Adoo
feat(canvas): auto merge path and render command
71d840d
@M-Adoo
feat: vert shader
a932661
@M-Adoo
feat: base path draw work
a709e96
@M-Adoo
feat(canvas): canvas 2d use a coordinate system like web 2d
6c2d122
@M-Adoo
refactor: remove path_finder and use canvas replace it
7cd887f
@M-Adoo
feat: add a texture frame support draw as a image.
efe5bc4
@M-Adoo
ci: fix grcov compile flags
24365fb
@M-Adoo
test(canvas): add gpu unit test framework support
1070927 
1. Support main thread only test and print message like what official print.
2. Add utils function to support image compare
3. Add a feature `main-thread-test` to individual those tests.
@M-Adoo
ci: just test on osx only in develop early phase
00859c6
@M-Adoo
style: clippy fix
c153adb
@M-Adoo M-Adoo marked this pull request as ready for review May 8, 2020 14:56
@M-Adoo M-Adoo requested a review from wjian23 May 8, 2020 14:57
@codecov
Copy link

codecov bot commented May 8, 2020 •
edited
Loading

Codecov Report

Merging #9 into master will decrease coverage by 12.25%.
The diff coverage is 41.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #9       +/-   ##
===========================================
- Coverage   60.00%   47.74%   -12.26%     
===========================================
  Files          16       22        +6     
  Lines         855     1552      +697     
===========================================
+ Hits          513      741      +228     
- Misses        342      811      +469
Impacted Files Coverage Δ
canvas/src/canvas.rs 0.00% <0.00%> (ø)
canvas/src/lib.rs 0.00% <0.00%> (ø)
core/src/application.rs 0.00% <0.00%> (-83.34%) ⬇️
core/src/render.rs 85.71% <0.00%> (-4.29%) ⬇️
core/src/render/painting_context.rs 0.00% <0.00%> (ø)
core/src/render_object.rs 0.00% <0.00%> (ø)
core/src/widget/row_layout.rs 69.23% <0.00%> (-20.77%) ⬇️
core/src/widget/window.rs 0.00% <0.00%> (ø)
examples/todos/src/main.rs 0.00% <0.00%> (ø)
lib.rs 2.98% <ø> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ce0fc1...3c91d10. Read the comment docs.

@M-Adoo
ci: add ubuntu-latest test on ci,
f749f9e 
OSX code corverage block on rust-lang/rust#63047, so add ubuntu support
advance
M-Adoo
M-Adoo commented May 9, 2020
View reviewed changes
Copy link
Collaborator Author

@M-Adoo M-Adoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self reviewed.

@M-Adoo M-Adoo requested a review from sologeek May 10, 2020 15:41
sologeek
sologeek previously approved these changes May 11, 2020
View reviewed changes
@M-Adoo M-Adoo merged commit 46383ef into master May 14, 2020
@M-Adoo M-Adoo deleted the feat-painting branch May 14, 2020 17:10
@M-Adoo M-Adoo mentioned this pull request May 21, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sologeek sologeek sologeek left review comments

@wjian23 wjian23 Awaiting requested review from wjian23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-Adoo @sologeek