Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlap Changes #93

Merged
merged 9 commits into from
Mar 28, 2018
Merged

Overlap Changes #93

merged 9 commits into from
Mar 28, 2018

Conversation

mhickle
Copy link
Contributor

@mhickle mhickle commented Oct 17, 2017

Overlap found with:
.navbar
.dropdown-menu
.alert
.active
.hidden
Changed to:
.wc-navbar
.wc-dropdown-menu
wc-.alert
.wc-active
.wc-hidden

Overlap found with:
.navbar
.dropdown-menu
.alert
.active
.hidden
Changed to:
.wc-navbar
.wc-dropdown-menu
wc-.alert
.wc-active
.wc-hidden
@mhickle mhickle changed the title Update aeTable.css Overlap Changes Oct 17, 2017
@jwildfire jwildfire self-requested a review October 18, 2017 14:56
Copy link
Contributor

@jwildfire jwildfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update js in /src folder where these classes are assigned.

@jwildfire jwildfire modified the milestone: v3.2.3 Feb 5, 2018
@jwildfire jwildfire self-assigned this Feb 5, 2018
@jwildfire jwildfire added this to the v3.2.6 milestone Feb 5, 2018
@samussiah samussiah changed the base branch from master to v3.2.6-dev March 22, 2018 20:07
@samussiah samussiah requested review from samussiah and pburnsdata and removed request for samussiah March 22, 2018 20:08
Copy link
Contributor

@pburnsdata pburnsdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw a few of the old classes in the build, I'll try and find them in src and request Spencer's review

@pburnsdata pburnsdata assigned pburnsdata and unassigned jwildfire Mar 22, 2018
@@ -5,7 +5,7 @@
export function layout() {
var wrapper = this.wrap
.append('div')
.attr('class', 'aeTable row-fluid')
Copy link
Contributor

@pburnsdata pburnsdata Mar 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samussiah I don't understand this update, so wanted to draw your attention to it - this isn't on the list in the pr comment and the class row-fluid still remains below

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like we need it, although it is a bootstrap class. Go ahead and remove row-fluid, wc-row-fluid, and form-inline. They're not referenced anywhere else.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samussiah Sounds good, removed those classes

@pburnsdata pburnsdata requested a review from samussiah March 22, 2018 20:53
Copy link
Contributor

@samussiah samussiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much obliged.

@pburnsdata pburnsdata merged commit 757486b into v3.2.6-dev Mar 28, 2018
@pburnsdata pburnsdata deleted the css-files branch March 28, 2018 14:05
@danedexF5
Copy link

@samussiah @emmorris I do not see any overlapping of columns on any of the three browsers. I compared them side by side with one having bootstrap toggled off and one with it on. There were some small css differences but nothing that was a big concern (coloring of Category names, Search bar in center of the page). When details are expanded and bootstrap is off they are sort of smushed together but not overlapped, basically, it doesn't look as nice. If you'd like me to test it in another way, I can do that, otherwise I think it's good.

@samussiah
Copy link
Contributor

Nope, that'll do it!

@emmorris
Copy link

I agree that should be sufficient testing. I looked them over a bit and saw the same types of differences.

With Bootstrap on:

  • Font style is slightly different
  • Search box is in the far right corner instead of closer to the middle
  • Category names are blue instead of black
  • When you search the number of matches is in a green box with white text instead of just plain black text
  • There is slightly less vertical spacing between boxes in the header section
  • When you search on a term and clear the search, the category names that were highlighted as a search result are black text instead of blue
  • The "Return to Summary View" button is larger and blue with white text instead of grey with black text
  • There are horizontal lines between each subject record in the listing view

These are all minor and I confirmed that all of them except the vertical spacing and horizontal line ones are already in the latest version of the renderer in RhoMAP, so I don't think this CSS update negatively impacted anything. We can discuss whether or not the other differences are worth addressing later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants