Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for HID SAM communication with SEOS cards #2704

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

jkramarz
Copy link

@jkramarz jkramarz commented Jan 4, 2025

No description provided.

Copy link

github-actions bot commented Jan 4, 2025

You are welcome to add an entry to the CHANGELOG.md as well

armsrc/sam_seos.c Outdated Show resolved Hide resolved
@iceman1001
Copy link
Collaborator

You also got a breaking build.
wrong type of the variable which pointer you are sending into the fct.

image

@jkramarz
Copy link
Author

jkramarz commented Jan 5, 2025

You also got a breaking build. wrong type of the variable which pointer you are sending into the fct.

I put a cast there now to silence the warning, as it's big enough.

I'll cleanup unnecessary code duplication between cmdhfseos.c and cmdhficlass.c and add one more small feature soon.

@iceman1001
Copy link
Collaborator

Lemme know when you think you are ready for merge

@jkramarz jkramarz changed the title WIP: support for HID SAM communication with SEOS cards support for HID SAM communication with SEOS cards Jan 6, 2025
@jkramarz
Copy link
Author

jkramarz commented Jan 6, 2025

@iceman1001, it's cleaned up and rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants