Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom suffix for hf mf autopwn to -o argument #2703

Merged

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Jan 4, 2025

This is because hf mf autopwn is the most used command and this can be used as "taking notes", to prevent causing a not sortable file list after long time use.

usage:

hf mf autopwn -o front_door
hf mf autopwn -o "front_door"

Copy link

github-actions bot commented Jan 4, 2025

You are welcome to add an entry to the CHANGELOG.md as well

@zxkmm zxkmm marked this pull request as ready for review January 4, 2025 13:24
CHANGELOG.md Outdated Show resolved Hide resolved
client/src/cmdhfmf.c Outdated Show resolved Hide resolved
client/src/cmdhfmf.c Outdated Show resolved Hide resolved
@zxkmm
Copy link
Contributor Author

zxkmm commented Jan 4, 2025

Thank you for the review!

  • fixed changelog
  • for the file name buffer i thought check itself is safer but i think check len is safe enough too, so I changed it to yours. I didn't carefully think if there would be edge cases tho.
  • for the long argument, would you mind tell me why it's better to not define long argument? I already do that as your request but just curious why.

doc/cheatsheet.md Outdated Show resolved Hide resolved
@iceman1001
Copy link
Collaborator

We are trying not to have "long_parameter_names" since it will fill up out screen space. Think people using it on phones. So even if you need a "long" parameter, try making as short as possible. In this case "output" doesn't add anything. We could have used "out" but feels a bit odd. just making a short -o is enough since its one of the "reserved" parameter names like -f ..

@iceman1001 iceman1001 merged commit 73b3b4d into RfidResearchGroup:master Jan 4, 2025
11 checks passed
@iceman1001
Copy link
Collaborator

Thanks for the fast changes!

@zxkmm
Copy link
Contributor Author

zxkmm commented Jan 4, 2025

We are trying not to have "long_parameter_names" since it will fill up out screen space. Think people using it on phones. So even if you need a "long" parameter, try making as short as possible. In this case "output" doesn't add anything. We could have used "out" but feels a bit odd. just making a short -o is enough since its one of the "reserved" parameter names like -f ..

Thanks for the explanation!

@zxkmm zxkmm deleted the custom_write_file_name_tail branch January 4, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants