Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move keys library to spiffs #2697

Merged

Conversation

piotrva
Copy link
Contributor

@piotrva piotrva commented Dec 26, 2024

This change moves flash-stored key dictionaries (Mifare, iClass and T55XX) from statically allocated area at the end of FLASH memory to a file located under SPIFFS file system.
This also implements automatic writing of the keys to SPIFFS using legacy methods.

Things to note:

  • Currently there seem to be no implementation/use of iClass keys stored in flash, so this change only transfers all the keys to SPIFFS file
  • In the future it will be a good idea to consider extension of SPIFFS into the last page of FLASH, as currently most of the page is left blank.
  • The change was tested using Proxmark3 RDV4.01 and some Mifare Classic 1k cards and some T5577 tags.
  • Cross-testing by other users would be more than welcome.

image
image
image
image

@piotrva piotrva marked this pull request as draft December 26, 2024 14:55
@piotrva piotrva marked this pull request as ready for review December 26, 2024 19:26
@iceman1001
Copy link
Collaborator

Nice and it removed some redundant code.

@iceman1001 iceman1001 merged commit 2c72db9 into RfidResearchGroup:master Dec 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants