use Amiibo PACK if simulator PWD matches generated Amiibo PWD #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are welcome to add an entry to the CHANGELOG.md as well |
|
Not sure if this kind of check is a good one. |
gtalusan
changed the title
|
Okay, thanks for the feedback. Here's a change -- the PWD in emulator memory is fetched. If it matches the calculated Amiibo PWD, then the PACK is hardcoded to 8080 otherwise nothing happens. |
|
Thats more like it! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had pulled down and compiled latest after working through #1861 a week or so ago.
Last night, I dusted off my old 2DS XL and noticed that the Amiibo simulator wasn't working in the latest build. I thought it must be my 2DS XL, but tested it on my kids' Switch and it wasn't working either.
It looks like in a632577, the PACK was hardcoded to 00000000.
This patch will pull the PACK from the emulator memory and Amiibo simulation can work well again.
Do let me know if this not the preferred approach.
Thanks!